Apply suggestions from code review

Co-authored-by: beltram <[email protected]>
wireapp · Dec 14, 2022 · f44abd4 · f44abd4
1 parent f0dc510
commit f44abd4
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/crypto/Cargo.toml b/crypto/Cargo.toml
@@ -87,7 +87,7 @@ async-trait = "0.1"
 
 [target.'cfg(not(target_family = "wasm"))'.dev-dependencies]
 cryptobox = { git = "https://github.com/wireapp/cryptobox", tag = "v1.0.3" }
-proteus = { git = "https://github.com/wireapp//proteus", branch = "otak/fix-1.0.3", features = [] }
+proteus = { git = "https://github.com/wireapp//proteus", branch = "otak/fix-1.0.3" }
 
 [target.'cfg(not(target_family = "wasm"))'.dev-dependencies.criterion]
 version = "0.3"

diff --git a/crypto/src/proteus.rs b/crypto/src/proteus.rs
@@ -1042,6 +1042,9 @@ mod tests {
         assert_eq!(&decrypted, &message[..]);
 
         // CL-110 assertion
+        // Happens when a migrated client ratchets just after migration. It does not happen when ratchet is not required
+        // Having alice(A), bob(B) and migration(M), you can reproduce this behaviour with `[A->B][B->A] M [A->B][B->A]`
+        // However you won't reproduce it like this because migrated alice does not ratchet `[A->B][B->A] M [B->A][A->B]`
         let encrypted = bob.encrypt(&session_id, &message[..]);
         let decrypted = proteus_central
             .decrypt(&mut keystore, &session_id, &encrypted)