Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: replace merge-pr script with compiled version #881

Merged
merged 1 commit into from
Jan 23, 2025

Conversation

coriolinus
Copy link
Contributor

https://github.com/wireapp/merge-pr

This includes prebuilt artifacts for macos and linux so that in the unlikely event that this gets popular, people can just fetch it without needing a rust toolchain or long build times.

Uses cargo-dist to create the CI, and cargo-release to do a release.


PR Submission Checklist for internal contributors
  • The PR Title
    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@coriolinus coriolinus requested a review from a team as a code owner January 22, 2025 17:18
Copy link

github-actions bot commented Jan 22, 2025

🐰 Bencher Report

Branchprgn/chore/replace-merge-pr-with-compiled-version
Testbedubuntu-latest
Click to view all benchmark results
BenchmarkLatencymilliseconds (ms)
Commit add f(group size)/cs1/mem/1002📈 view plot
🚷 view threshold
18.64
Commit add f(group size)/cs1/mem/2📈 view plot
🚷 view threshold
6.81
Commit add f(group size)/cs1/mem/202📈 view plot
🚷 view threshold
9.38
Commit add f(group size)/cs1/mem/402📈 view plot
🚷 view threshold
11.79
Commit add f(group size)/cs1/mem/602📈 view plot
🚷 view threshold
14.68
Commit add f(group size)/cs1/mem/802📈 view plot
🚷 view threshold
16.62
Commit add f(number clients)/cs1/mem/1002📈 view plot
🚷 view threshold
1,002.50
Commit add f(number clients)/cs1/mem/2📈 view plot
🚷 view threshold
6.82
Commit add f(number clients)/cs1/mem/202📈 view plot
🚷 view threshold
85.51
Commit add f(number clients)/cs1/mem/402📈 view plot
🚷 view threshold
223.91
Commit add f(number clients)/cs1/mem/602📈 view plot
🚷 view threshold
431.10
Commit add f(number clients)/cs1/mem/802📈 view plot
🚷 view threshold
678.89
Commit pending proposals f(group size)/cs1/mem/1002📈 view plot
🚷 view threshold
115.71
Commit pending proposals f(group size)/cs1/mem/2📈 view plot
🚷 view threshold
28.40
Commit pending proposals f(group size)/cs1/mem/202📈 view plot
🚷 view threshold
45.99
Commit pending proposals f(group size)/cs1/mem/402📈 view plot
🚷 view threshold
60.87
Commit pending proposals f(group size)/cs1/mem/602📈 view plot
🚷 view threshold
79.22
Commit pending proposals f(group size)/cs1/mem/802📈 view plot
🚷 view threshold
93.90
Commit pending proposals f(pending size)/cs1/mem/1📈 view plot
🚷 view threshold
18.67
Commit pending proposals f(pending size)/cs1/mem/101📈 view plot
🚷 view threshold
115.25
Commit pending proposals f(pending size)/cs1/mem/21📈 view plot
🚷 view threshold
35.24
Commit pending proposals f(pending size)/cs1/mem/41📈 view plot
🚷 view threshold
56.23
Commit pending proposals f(pending size)/cs1/mem/61📈 view plot
🚷 view threshold
75.61
Commit pending proposals f(pending size)/cs1/mem/81📈 view plot
🚷 view threshold
95.17
Commit remove f(group size)/cs1/mem/1002📈 view plot
🚷 view threshold
27.70
Commit remove f(group size)/cs1/mem/2📈 view plot
🚷 view threshold
6.74
Commit remove f(group size)/cs1/mem/202📈 view plot
🚷 view threshold
8.96
Commit remove f(group size)/cs1/mem/402📈 view plot
🚷 view threshold
11.73
Commit remove f(group size)/cs1/mem/602📈 view plot
🚷 view threshold
17.16
Commit remove f(group size)/cs1/mem/802📈 view plot
🚷 view threshold
21.71
Commit remove f(number clients)/cs1/mem/1002📈 view plot
🚷 view threshold
29.62
Commit remove f(number clients)/cs1/mem/2📈 view plot
🚷 view threshold
137.57
Commit remove f(number clients)/cs1/mem/202📈 view plot
🚷 view threshold
115.16
Commit remove f(number clients)/cs1/mem/402📈 view plot
🚷 view threshold
93.70
Commit remove f(number clients)/cs1/mem/602📈 view plot
🚷 view threshold
71.53
Commit remove f(number clients)/cs1/mem/802📈 view plot
🚷 view threshold
50.86
Commit update f(group size)/cs1/mem/1002📈 view plot
🚷 view threshold
137.56
Commit update f(group size)/cs1/mem/2📈 view plot
🚷 view threshold
6.96
Commit update f(group size)/cs1/mem/202📈 view plot
🚷 view threshold
33.39
Commit update f(group size)/cs1/mem/402📈 view plot
🚷 view threshold
59.63
Commit update f(group size)/cs1/mem/602📈 view plot
🚷 view threshold
86.70
Commit update f(group size)/cs1/mem/802📈 view plot
🚷 view threshold
112.11
🐰 View full continuous benchmarking report in Bencher

<https://github.com/wireapp/merge-pr>

This includes prebuilt artifacts for macos and linux so that
in the unlikely event that this gets popular, people can just
fetch it without needing a rust toolchain or long build times.

Uses `cargo-dist` to create the CI, and `cargo-release` to do a release.
@coriolinus coriolinus force-pushed the prgn/chore/replace-merge-pr-with-compiled-version branch from ba9f218 to b20751b Compare January 23, 2025 12:54
@coriolinus coriolinus merged commit b20751b into main Jan 23, 2025
8 checks passed
@coriolinus coriolinus deleted the prgn/chore/replace-merge-pr-with-compiled-version branch January 23, 2025 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants