Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: ignore bun's new textual lockfile #898

Merged
merged 1 commit into from
Jan 31, 2025

Conversation

coriolinus
Copy link
Contributor

When setting up a new workspace or after a clean action, we will not have the bun lockfile cached, and bun will create a new one. This is now by default in a textual file format which has a slightly different filename. We want to ignore that also.


PR Submission Checklist for internal contributors
  • The PR Title
    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@coriolinus coriolinus requested a review from a team as a code owner January 31, 2025 11:17
Copy link

github-actions bot commented Jan 31, 2025

🐰 Bencher Report

Branchprgn/chore/ignore-bun-text-lockfile
Testbedubuntu-latest
Click to view all benchmark results
BenchmarkLatencymilliseconds (ms)
Commit add f(group size)/cs1/mem/1002📈 view plot
🚷 view threshold
19.23
Commit add f(group size)/cs1/mem/2📈 view plot
🚷 view threshold
6.88
Commit add f(group size)/cs1/mem/202📈 view plot
🚷 view threshold
9.31
Commit add f(group size)/cs1/mem/402📈 view plot
🚷 view threshold
15.29
Commit add f(group size)/cs1/mem/602📈 view plot
🚷 view threshold
15.05
Commit add f(group size)/cs1/mem/802📈 view plot
🚷 view threshold
17.09
Commit add f(number clients)/cs1/mem/1002📈 view plot
🚷 view threshold
986.89
Commit add f(number clients)/cs1/mem/2📈 view plot
🚷 view threshold
6.77
Commit add f(number clients)/cs1/mem/202📈 view plot
🚷 view threshold
84.83
Commit add f(number clients)/cs1/mem/402📈 view plot
🚷 view threshold
221.38
Commit add f(number clients)/cs1/mem/602📈 view plot
🚷 view threshold
427.65
Commit add f(number clients)/cs1/mem/802📈 view plot
🚷 view threshold
673.84
Commit pending proposals f(group size)/cs1/mem/1002📈 view plot
🚷 view threshold
116.77
Commit pending proposals f(group size)/cs1/mem/2📈 view plot
🚷 view threshold
28.58
Commit pending proposals f(group size)/cs1/mem/202📈 view plot
🚷 view threshold
46.15
Commit pending proposals f(group size)/cs1/mem/402📈 view plot
🚷 view threshold
61.09
Commit pending proposals f(group size)/cs1/mem/602📈 view plot
🚷 view threshold
79.85
Commit pending proposals f(group size)/cs1/mem/802📈 view plot
🚷 view threshold
95.95
Commit pending proposals f(pending size)/cs1/mem/1📈 view plot
🚷 view threshold
19.14
Commit pending proposals f(pending size)/cs1/mem/101📈 view plot
🚷 view threshold
117.11
Commit pending proposals f(pending size)/cs1/mem/21📈 view plot
🚷 view threshold
36.44
Commit pending proposals f(pending size)/cs1/mem/41📈 view plot
🚷 view threshold
57.43
Commit pending proposals f(pending size)/cs1/mem/61📈 view plot
🚷 view threshold
75.79
Commit pending proposals f(pending size)/cs1/mem/81📈 view plot
🚷 view threshold
96.15
Commit remove f(group size)/cs1/mem/1002📈 view plot
🚷 view threshold
28.00
Commit remove f(group size)/cs1/mem/2📈 view plot
🚷 view threshold
6.77
Commit remove f(group size)/cs1/mem/202📈 view plot
🚷 view threshold
8.72
Commit remove f(group size)/cs1/mem/402📈 view plot
🚷 view threshold
11.88
Commit remove f(group size)/cs1/mem/602📈 view plot
🚷 view threshold
17.72
Commit remove f(group size)/cs1/mem/802📈 view plot
🚷 view threshold
22.11
Commit remove f(number clients)/cs1/mem/1002📈 view plot
🚷 view threshold
31.23
Commit remove f(number clients)/cs1/mem/2📈 view plot
🚷 view threshold
137.27
Commit remove f(number clients)/cs1/mem/202📈 view plot
🚷 view threshold
115.09
Commit remove f(number clients)/cs1/mem/402📈 view plot
🚷 view threshold
93.87
Commit remove f(number clients)/cs1/mem/602📈 view plot
🚷 view threshold
72.20
Commit remove f(number clients)/cs1/mem/802📈 view plot
🚷 view threshold
51.15
Commit update f(group size)/cs1/mem/1002📈 view plot
🚷 view threshold
138.07
Commit update f(group size)/cs1/mem/2📈 view plot
🚷 view threshold
7.07
Commit update f(group size)/cs1/mem/202📈 view plot
🚷 view threshold
33.63
Commit update f(group size)/cs1/mem/402📈 view plot
🚷 view threshold
60.24
Commit update f(group size)/cs1/mem/602📈 view plot
🚷 view threshold
86.99
Commit update f(group size)/cs1/mem/802📈 view plot
🚷 view threshold
112.45
🐰 View full continuous benchmarking report in Bencher

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.40%. Comparing base (461ff0f) to head (208cb18).
Report is 9 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #898      +/-   ##
==========================================
- Coverage   78.44%   78.40%   -0.05%     
==========================================
  Files         113      113              
  Lines       20097    20166      +69     
==========================================
+ Hits        15766    15811      +45     
- Misses       4331     4355      +24     

see 18 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 461ff0f...208cb18. Read the comment docs.

When setting up a new workspace or after a clean action, we will
not have the bun lockfile cached, and bun will create a new one.
This is now by default in a textual file format which has a slightly
different filename. We want to ignore that also.
@coriolinus coriolinus force-pushed the prgn/chore/ignore-bun-text-lockfile branch from 208cb18 to 061fd2a Compare January 31, 2025 12:58
@coriolinus coriolinus merged commit 061fd2a into main Jan 31, 2025
@coriolinus coriolinus deleted the prgn/chore/ignore-bun-text-lockfile branch January 31, 2025 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants