Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release: v3.0.2 #899

Merged
merged 2 commits into from
Jan 31, 2025
Merged

release: v3.0.2 #899

merged 2 commits into from
Jan 31, 2025

Conversation

coriolinus
Copy link
Contributor


PR Submission Checklist for internal contributors
  • The PR Title
    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

coriolinus and others added 2 commits January 31, 2025 12:22
Apparently the `CoreCryptoError.fromStdError()` function does not work as expected.

We can easily fix error type mapping by doing an early return at least for the cases
where this function is called with an error that is already an instance of `CoreCryptoError`.

Now calling this function at least doesn't make things worse.

Co-authored-by: Simon Thormeyer <[email protected]>
@coriolinus coriolinus requested a review from a team as a code owner January 31, 2025 11:32
Copy link

github-actions bot commented Jan 31, 2025

🐰 Bencher Report

Branchprepare-release/3.0.2
Testbedubuntu-latest

⚠️ WARNING: No Threshold found!

Without a Threshold, no Alerts will ever be generated.

Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the --ci-only-thresholds CLI flag.

Click to view all benchmark results
BenchmarkLatencymilliseconds (ms)
Commit add f(group size)/cs1/mem/1002📈 view plot
⚠️ NO THRESHOLD
18.67
Commit add f(group size)/cs1/mem/2📈 view plot
⚠️ NO THRESHOLD
6.90
Commit add f(group size)/cs1/mem/202📈 view plot
⚠️ NO THRESHOLD
9.39
Commit add f(group size)/cs1/mem/402📈 view plot
⚠️ NO THRESHOLD
11.82
Commit add f(group size)/cs1/mem/602📈 view plot
⚠️ NO THRESHOLD
14.89
Commit add f(group size)/cs1/mem/802📈 view plot
⚠️ NO THRESHOLD
16.74
Commit add f(number clients)/cs1/mem/1002📈 view plot
⚠️ NO THRESHOLD
993.71
Commit add f(number clients)/cs1/mem/2📈 view plot
⚠️ NO THRESHOLD
6.87
Commit add f(number clients)/cs1/mem/202📈 view plot
⚠️ NO THRESHOLD
85.23
Commit add f(number clients)/cs1/mem/402📈 view plot
⚠️ NO THRESHOLD
222.84
Commit add f(number clients)/cs1/mem/602📈 view plot
⚠️ NO THRESHOLD
429.21
Commit add f(number clients)/cs1/mem/802📈 view plot
⚠️ NO THRESHOLD
684.06
Commit pending proposals f(group size)/cs1/mem/1002📈 view plot
⚠️ NO THRESHOLD
116.78
Commit pending proposals f(group size)/cs1/mem/2📈 view plot
⚠️ NO THRESHOLD
28.42
Commit pending proposals f(group size)/cs1/mem/202📈 view plot
⚠️ NO THRESHOLD
47.91
Commit pending proposals f(group size)/cs1/mem/402📈 view plot
⚠️ NO THRESHOLD
61.14
Commit pending proposals f(group size)/cs1/mem/602📈 view plot
⚠️ NO THRESHOLD
79.94
Commit pending proposals f(group size)/cs1/mem/802📈 view plot
⚠️ NO THRESHOLD
94.96
Commit pending proposals f(pending size)/cs1/mem/1📈 view plot
⚠️ NO THRESHOLD
18.86
Commit pending proposals f(pending size)/cs1/mem/101📈 view plot
⚠️ NO THRESHOLD
115.69
Commit pending proposals f(pending size)/cs1/mem/21📈 view plot
⚠️ NO THRESHOLD
35.51
Commit pending proposals f(pending size)/cs1/mem/41📈 view plot
⚠️ NO THRESHOLD
57.04
Commit pending proposals f(pending size)/cs1/mem/61📈 view plot
⚠️ NO THRESHOLD
76.28
Commit pending proposals f(pending size)/cs1/mem/81📈 view plot
⚠️ NO THRESHOLD
96.45
Commit remove f(group size)/cs1/mem/1002📈 view plot
⚠️ NO THRESHOLD
27.46
Commit remove f(group size)/cs1/mem/2📈 view plot
⚠️ NO THRESHOLD
6.77
Commit remove f(group size)/cs1/mem/202📈 view plot
⚠️ NO THRESHOLD
8.83
Commit remove f(group size)/cs1/mem/402📈 view plot
⚠️ NO THRESHOLD
12.03
Commit remove f(group size)/cs1/mem/602📈 view plot
⚠️ NO THRESHOLD
17.11
Commit remove f(group size)/cs1/mem/802📈 view plot
⚠️ NO THRESHOLD
21.95
Commit remove f(number clients)/cs1/mem/1002📈 view plot
⚠️ NO THRESHOLD
30.10
Commit remove f(number clients)/cs1/mem/2📈 view plot
⚠️ NO THRESHOLD
136.88
Commit remove f(number clients)/cs1/mem/202📈 view plot
⚠️ NO THRESHOLD
114.86
Commit remove f(number clients)/cs1/mem/402📈 view plot
⚠️ NO THRESHOLD
94.44
Commit remove f(number clients)/cs1/mem/602📈 view plot
⚠️ NO THRESHOLD
72.12
Commit remove f(number clients)/cs1/mem/802📈 view plot
⚠️ NO THRESHOLD
51.14
Commit update f(group size)/cs1/mem/1002📈 view plot
⚠️ NO THRESHOLD
137.38
Commit update f(group size)/cs1/mem/2📈 view plot
⚠️ NO THRESHOLD
6.83
Commit update f(group size)/cs1/mem/202📈 view plot
⚠️ NO THRESHOLD
33.41
Commit update f(group size)/cs1/mem/402📈 view plot
⚠️ NO THRESHOLD
59.91
Commit update f(group size)/cs1/mem/602📈 view plot
⚠️ NO THRESHOLD
86.96
Commit update f(group size)/cs1/mem/802📈 view plot
⚠️ NO THRESHOLD
112.07
🐰 View full continuous benchmarking report in Bencher

@coriolinus coriolinus merged commit 052e17c into release/3.x Jan 31, 2025
30 checks passed
@coriolinus coriolinus deleted the prepare-release/3.0.2 branch January 31, 2025 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants