chore: address comments

wireapp · Nov 30, 2023 · fe6e61e · fe6e61e
1 parent 4f5a295
commit fe6e61e
Show file tree

Hide file tree

Showing 5 changed files with 75 additions and 1 deletion.
diff --git a/...c/src/commonMain/kotlin/com/wire/kalium/logic/data/conversation/ConversationRepository.kt b/...c/src/commonMain/kotlin/com/wire/kalium/logic/data/conversation/ConversationRepository.kt
@@ -287,6 +287,13 @@ interface ConversationRepository {
         conversationId: QualifiedID,
         value: Boolean
     ): Either<CoreFailure, Unit>
+
+    suspend fun updateLegalHoldStatus(
+        conversationId: ConversationId,
+        legalHoldStatus: Conversation.LegalHoldStatus
+    ): Either<CoreFailure, Unit>
+
+    suspend fun observeLegalHoldForConversation(conversationId: ConversationId): Flow<Either<StorageFailure, Conversation.LegalHoldStatus>>
 }
 
 @Suppress("LongParameterList", "TooManyFunctions", "LargeClass")
@@ -1074,6 +1081,24 @@ internal class ConversationDataSource internal constructor(
             .wrapStorageRequest()
             .mapToRightOr(true)
 
+    override suspend fun updateLegalHoldStatus(
+        conversationId: ConversationId,
+        legalHoldStatus: Conversation.LegalHoldStatus
+    ): Either<CoreFailure, Unit> {
+        val legalHoldStatusEntity = conversationMapper.legalHoldStatusToEntity(legalHoldStatus)
+        return wrapStorageRequest {
+            conversationDAO.updateLegalHoldStatus(
+                conversationId = conversationId.toDao(),
+                legalHoldStatus = legalHoldStatusEntity
+            )
+        }
+    }
+
+    override suspend fun observeLegalHoldForConversation(conversationId: ConversationId) =
+        conversationDAO.observeLegalHoldForConversation(conversationId.toDao())
+            .map { conversationMapper.legalHoldStatusFromEntity(it) }
+            .wrapStorageRequest()
+
     companion object {
         const val DEFAULT_MEMBER_ROLE = "wire_member"
     }

diff --git a/...c/commonTest/kotlin/com/wire/kalium/logic/data/conversation/ConversationRepositoryTest.kt b/...c/commonTest/kotlin/com/wire/kalium/logic/data/conversation/ConversationRepositoryTest.kt
@@ -1319,6 +1319,33 @@ class ConversationRepositoryTest {
         }
     }
 
+    @Test
+    fun givenLegalHoldStatus_whenUpdateIsCalled_thenInvokeUpdateLegalHoldStatusFromOnce() = runTest {
+        val (arrange, conversationRepository) = Arrangement()
+            .arrange()
+
+        conversationRepository.updateLegalHoldStatus(CONVERSATION_ID, Conversation.LegalHoldStatus.ENABLED)
+
+        verify(arrange.conversationDAO)
+            .suspendFunction(arrange.conversationDAO::updateLegalHoldStatus)
+            .with(eq(CONVERSATION_ID.toDao()), any())
+            .wasInvoked(exactly = once)
+    }
+
+    @Test
+    fun givenConversationId_whenObservingLegalHoldStatus_thenInvokeObserveLegalHoldStatusFromOnce() = runTest {
+        val (arrange, conversationRepository) = Arrangement()
+            .withObserveLegalHoldStatus()
+            .arrange()
+
+        conversationRepository.observeLegalHoldForConversation(CONVERSATION_ID)
+
+        verify(arrange.conversationDAO)
+            .suspendFunction(arrange.conversationDAO::observeLegalHoldForConversation)
+            .with(eq(CONVERSATION_ID.toDao()))
+            .wasInvoked(exactly = once)
+    }
+
     private class Arrangement :
         MemberDAOArrangement by MemberDAOArrangementImpl() {
 
@@ -1683,6 +1710,13 @@ class ConversationRepositoryTest {
                 .thenReturn(response)
         }
 
+        fun withObserveLegalHoldStatus() = apply {
+            given(conversationDAO)
+                .suspendFunction(conversationDAO::observeLegalHoldForConversation)
+                .whenInvokedWith(any())
+                .thenReturn(flowOf(ConversationEntity.LegalHoldStatus.ENABLED))
+        }
+
         fun arrange() = this to conversationRepository
     }
 

diff --git a/persistence/src/commonMain/db_user/migrations/21.sqm b/persistence/src/commonMain/db_user/migrations/21.sqm
@@ -1,7 +1,7 @@
 import com.wire.kalium.persistence.dao.conversation.ConversationEntity;
 
 DROP VIEW ConversationDetails;
-ALTER TABLE Conversation ADD COLUMN receipt_mode TEXT AS ConversationEntity.ReceiptMode DEFAULT "DISABLED";
+ALTER TABLE Conversation ADD COLUMN receipt_mode TEXT AS ConversationEntity.ReceiptMode DEFAULT "DISABLED" NOT NULL;
 
 CREATE VIEW IF NOT EXISTS ConversationDetails AS
 SELECT

diff --git a/...nce/src/commonMain/kotlin/com/wire/kalium/persistence/dao/conversation/ConversationDAO.kt b/...nce/src/commonMain/kotlin/com/wire/kalium/persistence/dao/conversation/ConversationDAO.kt
@@ -109,4 +109,6 @@ interface ConversationDAO {
     suspend fun observeUnreadArchivedConversationsCount(): Flow<Long>
     suspend fun observeDegradedConversationNotified(conversationId: QualifiedIDEntity): Flow<Boolean>
     suspend fun updateDegradedConversationNotifiedFlag(conversationId: QualifiedIDEntity, updateFlag: Boolean)
+    suspend fun updateLegalHoldStatus(conversationId: QualifiedIDEntity, legalHoldStatus: ConversationEntity.LegalHoldStatus)
+    suspend fun observeLegalHoldForConversation(conversationId: QualifiedIDEntity): Flow<ConversationEntity.LegalHoldStatus>
 }
diff --git a/...src/commonMain/kotlin/com/wire/kalium/persistence/dao/conversation/ConversationDAOImpl.kt b/...src/commonMain/kotlin/com/wire/kalium/persistence/dao/conversation/ConversationDAOImpl.kt
@@ -399,4 +399,17 @@ internal class ConversationDAOImpl internal constructor(
     override suspend fun observeUnreadArchivedConversationsCount(): Flow<Long> =
         unreadEventsQueries.getUnreadArchivedConversationsCount().asFlow().mapToOne()
 
+    override suspend fun updateLegalHoldStatus(
+        conversationId: QualifiedIDEntity,
+        legalHoldStatus: ConversationEntity.LegalHoldStatus
+    ) = withContext(coroutineContext) {
+        conversationQueries.updateLegalHoldStatus(legalHoldStatus, conversationId)
+    }
+
+    override suspend fun observeLegalHoldForConversation(conversationId: QualifiedIDEntity) =
+        conversationQueries.selectLegalHoldStatus(conversationId)
+            .asFlow()
+            .mapToOneOrDefault(ConversationEntity.LegalHoldStatus.DISABLED)
+            .flowOn(coroutineContext)
+
 }