Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(monkeys): Add and expose metrics of the text execution [WPB-4445] #2043

Merged
merged 3 commits into from
Sep 8, 2023

Conversation

augustocdias
Copy link


PR Submission Checklist for internal contributors

  • The PR Title
    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³

What's new in this PR?

Exposes metrics in prometheus format at runtime on the port 9090. With that, tests can be monitored at runtime about it's state and performance. Now there'll always be a log file for the application and it was split from the kalium log. A custom log file can be specified, otherwise it will be $CWD/monkeys.log


References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2023

Unit Test Results

   412 files   - 20     412 suites   - 20   23s ⏱️ - 2m 21s
2 252 tests  - 99  2 132 ✔️  - 116  120 💤 +17  0 ±0 

Results for commit 52bc9cd. ± Comparison against base commit 8be83c1.

♻️ This comment has been updated with latest results.

@codecov-commenter
Copy link

codecov-commenter commented Sep 7, 2023

Codecov Report

Merging #2043 (52bc9cd) into develop (8be83c1) will decrease coverage by 0.01%.
Report is 4 commits behind head on develop.
The diff coverage is n/a.

@@              Coverage Diff              @@
##             develop    #2043      +/-   ##
=============================================
- Coverage      57.98%   57.98%   -0.01%     
  Complexity        24       24              
=============================================
  Files           1006     1006              
  Lines          37646    37667      +21     
  Branches        3409     3411       +2     
=============================================
+ Hits           21830    21840      +10     
- Misses         14360    14370      +10     
- Partials        1456     1457       +1     

see 6 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8be83c1...52bc9cd. Read the comment docs.

📢 Have feedback on the report? Share it here.

@datadog-wireapp
Copy link

datadog-wireapp bot commented Sep 7, 2023

Datadog Report

All test runs 276fd87 🔗

2 Total Test Services: 0 Failed, 0 with New Flaky, 2 Passed

Test Services
Service Name Failed Known Flaky New Flaky Passed Skipped Wall Time Branch View
kalium-ios 0 0 0 2132 120 10m 3.09s Link
kalium-jvm 0 0 0 2251 103 9m 51s Link

@augustocdias augustocdias marked this pull request as ready for review September 7, 2023 11:33
Copy link
Member

@vitorhugods vitorhugods left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👨🏼‍🍳🤌🏻

Copy link
Member

@typfel typfel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool 😎

@typfel
Copy link
Member

typfel commented Sep 7, 2023

@augustocdias do you have some example statistics from a run?

@augustocdias
Copy link
Author

@augustocdias do you have some example statistics from a run?

@typfel this is a fragment of it. We have now to pre-configure a prometheus instance and grafana board to monitore it in real time.

# HELP g_loggedOutUsers  
# TYPE g_loggedOutUsers gauge
g_loggedOutUsers{domain="Elna",testCase="Example Test Case",} 0.0
# HELP g_loggedInUsers  
# TYPE g_loggedInUsers gauge
g_loggedInUsers{domain="Elna",testCase="Example Test Case",} 11.0
# HELP g_conversations  
# TYPE g_conversations gauge
g_conversations 4.0
# HELP g_conversationMembers  
# TYPE g_conversationMembers gauge
g_conversationMembers{id="[email protected]",} 1.0
g_conversationMembers{id="[email protected]",} 1.0
g_conversationMembers{id="[email protected]",} 1.0
g_conversationMembers{id="[email protected]",} 1.0

@augustocdias augustocdias added this pull request to the merge queue Sep 8, 2023
Merged via the queue into develop with commit 86088f8 Sep 8, 2023
@augustocdias augustocdias deleted the feat/monkeys/metrics branch September 8, 2023 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants