Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump sqldelight to 2.0.0 #2045

Merged
merged 8 commits into from
Sep 13, 2023
Merged

Conversation

MohamadJaara
Copy link
Member


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

bump sqldelight to 2.0.0


PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@github-actions

This comment has been minimized.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 12, 2023

Unit Test Results

   413 files   -   21     413 suites   - 21   23s ⏱️ - 2m 18s
2 255 tests  - 102  2 135 ✔️  - 119  120 💤 +17  0 ±0 

Results for commit 957e665. ± Comparison against base commit 3b87e90.

♻️ This comment has been updated with latest results.

@MohamadJaara MohamadJaara force-pushed the chore/bump-sqldelight-to-2.0.0 branch from 405df1c to 0e1a958 Compare September 13, 2023 13:46
# Conflicts:
#	gradle/libs.versions.toml
@datadog-wireapp
Copy link

datadog-wireapp bot commented Sep 13, 2023

Datadog Report

All test runs cbb3006 🔗

2 Total Test Services: 0 Failed, 0 with New Flaky, 2 Passed

Test Services
Service Name Failed Known Flaky New Flaky Passed Skipped Wall Time Branch View
kalium-ios 0 0 0 2135 120 13m 12.01s Link
kalium-jvm 0 0 0 2254 103 9m 56s Link

@codecov-commenter
Copy link

Codecov Report

Merging #2045 (957e665) into develop (3b87e90) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

@@              Coverage Diff              @@
##             develop    #2045      +/-   ##
=============================================
- Coverage      58.00%   57.98%   -0.02%     
  Complexity        24       24              
=============================================
  Files           1007     1007              
  Lines          37680    37691      +11     
  Branches        3414     3414              
=============================================
+ Hits           21856    21857       +1     
- Misses         14368    14378      +10     
  Partials        1456     1456              
Files Changed Coverage Δ
.../wire/kalium/persistence/db/UserDatabaseBuilder.kt 78.99% <0.00%> (-0.67%) ⬇️

... and 189 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b87e90...957e665. Read the comment docs.

@MohamadJaara MohamadJaara added this pull request to the merge queue Sep 13, 2023
Merged via the queue into develop with commit f847369 Sep 13, 2023
@MohamadJaara MohamadJaara deleted the chore/bump-sqldelight-to-2.0.0 branch September 13, 2023 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants