Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump ktor to 2.3.4 #2046

Merged
merged 1 commit into from
Sep 8, 2023
Merged

chore: bump ktor to 2.3.4 #2046

merged 1 commit into from
Sep 8, 2023

Conversation

MohamadJaara
Copy link
Member


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

bump ktor to 2.3.4


PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2023

Unit Test Results

   433 files  ±0     433 suites  ±0   3m 6s ⏱️ + 1m 7s
2 354 tests ±0  2 251 ✔️ ±0  103 💤 ±0  0 ±0 

Results for commit da94046. ± Comparison against base commit 4afd816.

♻️ This comment has been updated with latest results.

@ohassine ohassine enabled auto-merge September 8, 2023 09:50
@ohassine ohassine added this pull request to the merge queue Sep 8, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #2046 (da94046) into develop (4afd816) will decrease coverage by 0.01%.
Report is 2 commits behind head on develop.
The diff coverage is n/a.

@@              Coverage Diff              @@
##             develop    #2046      +/-   ##
=============================================
- Coverage      57.99%   57.98%   -0.01%     
  Complexity        24       24              
=============================================
  Files           1006     1006              
  Lines          37667    37667              
  Branches        3411     3411              
=============================================
- Hits           21844    21841       -3     
- Misses         14366    14370       +4     
+ Partials        1457     1456       -1     

see 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4afd816...da94046. Read the comment docs.

📢 Have feedback on the report? Share it here.

Merged via the queue into develop with commit b6e74c3 Sep 8, 2023
@ohassine ohassine deleted the chore/bump-ktor-to-2.3.4 branch September 8, 2023 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants