Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: looking for cryptobox files to migrate at wrong location WPB-4658 #2054

Merged
merged 1 commit into from
Sep 13, 2023

Conversation

typfel
Copy link
Member

@typfel typfel commented Sep 12, 2023


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Proteus Cryptobox migration to Proteus CoreCrypto fails (doesn't happen)

Causes

The path were we are looking for the cryptobox files are wrong (it includes the CC keystore file)

Solutions

Remove keystore suffix on path.


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@typfel typfel requested a review from vitorhugods September 12, 2023 13:38
@typfel typfel changed the title fix: looking for cryptobox files to migrate at wrong location fix: looking for cryptobox files to migrate at wrong location WPB-4658 Sep 12, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 12, 2023

Unit Test Results

   434 files  ±0     434 suites  ±0   2m 45s ⏱️ -33s
2 357 tests ±0  2 254 ✔️ ±0  103 💤 ±0  0 ±0 

Results for commit 81e52a3. ± Comparison against base commit 4bbf5a7.

♻️ This comment has been updated with latest results.

@typfel typfel added this pull request to the merge queue Sep 13, 2023
Merged via the queue into develop with commit 3b87e90 Sep 13, 2023
@typfel typfel deleted the fix/cryptobox-migration branch September 13, 2023 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants