Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: handle out of order MLS messages #2055

Merged
merged 4 commits into from
Sep 15, 2023
Merged

Conversation

typfel
Copy link
Member

@typfel typfel commented Sep 12, 2023


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

I'm re-opening #1958 because it seems to have gotten lost in a rebase.

After reviewing it again I've changed my approach.

  1. Handle out order buffered messages when decrypting a message.2
  2. Ignore CC's buffered messages when merging commits, because it's much easier and nicer to avoid out order message by enforcing the order of operations in Kalium.

Testing

Test Coveragex

  • I have added automated test to this contribution

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 12, 2023

Unit Test Results

   434 files  ±0     434 suites  ±0   2m 51s ⏱️ +13s
2 360 tests +2  2 257 ✔️ +2  103 💤 ±0  0 ±0 

Results for commit 5489d77. ± Comparison against base commit 38df69b.

♻️ This comment has been updated with latest results.

@datadog-wireapp
Copy link

datadog-wireapp bot commented Sep 12, 2023

Datadog Report

All test runs 4d6d87b 🔗

2 Total Test Services: 0 Failed, 0 with New Flaky, 2 Passed

Test Services
Service Name Failed Known Flaky New Flaky Passed Skipped Wall Time Branch View
kalium-ios 0 0 0 1645 56 7m 38s Link
kalium-jvm 0 0 0 2257 103 13m 51s Link

@typfel typfel force-pushed the feat/handle-out-order-messages branch from 62073a1 to 5489d77 Compare September 14, 2023 15:11
@typfel typfel added this pull request to the merge queue Sep 15, 2023
Merged via the queue into develop with commit 6a9ac7a Sep 15, 2023
@typfel typfel deleted the feat/handle-out-order-messages branch September 15, 2023 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants