-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add archived field to conversations table (WPB-4471) #2056
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Datadog ReportAll test runs ✅ 2 Total Test Services: 0 Failed, 0 with New Flaky, 2 Passed Test Services
|
typfel
reviewed
Sep 13, 2023
logic/src/commonMain/kotlin/com/wire/kalium/logic/data/connection/ConnectionRepository.kt
Outdated
Show resolved
Hide resolved
Garzas
approved these changes
Sep 13, 2023
vitorhugods
reviewed
Sep 13, 2023
logic/src/commonMain/kotlin/com/wire/kalium/logic/data/conversation/Conversation.kt
Outdated
Show resolved
Hide resolved
vitorhugods
approved these changes
Sep 14, 2023
logic/src/commonMain/kotlin/com/wire/kalium/logic/data/conversation/ConversationMapper.kt
Outdated
Show resolved
Hide resolved
MohamadJaara
approved these changes
Sep 14, 2023
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
echoes: product-roadmap
Work aligned with the customer-announced roadmap, targeting a specific release date.
🚨 Potential breaking changes
👕 size: L
type: chore 🧹
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Issues
We were retrieving
otr_archived
andotr_archived_ref
from the API but not persisting in the database.Solutions
Add
otr_archived
andotr_archived_ref
to conversation table when getting from API.Testing
Test Coverage (Optional)
How to Test
Currently the only way to test is:
Conversation
table and if you have any archived conversation, it should be represented as such (1 = true, 0 = false)