Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add archived field to conversations table (WPB-4471) #2056

Merged
merged 18 commits into from
Sep 14, 2023

Conversation

alexandreferris
Copy link
Contributor


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

We were retrieving otr_archived and otr_archived_ref from the API but not persisting in the database.

Solutions

Add otr_archived and otr_archived_ref to conversation table when getting from API.

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Currently the only way to test is:

  • Fresh install/login
  • check from App Inspection that you have both fields in the Conversation table and if you have any archived conversation, it should be represented as such (1 = true, 0 = false)

@alexandreferris alexandreferris self-assigned this Sep 13, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 13, 2023

Unit Test Results

   434 files  ±0     434 suites  ±0   3m 4s ⏱️ + 1m 4s
2 358 tests ±0  2 255 ✔️ ±0  103 💤 ±0  0 ±0 

Results for commit 1eea0de. ± Comparison against base commit b2a859c.

♻️ This comment has been updated with latest results.

@datadog-wireapp
Copy link

datadog-wireapp bot commented Sep 13, 2023

Datadog Report

All test runs c69f81e 🔗

2 Total Test Services: 0 Failed, 0 with New Flaky, 2 Passed

Test Services
Service Name Failed Known Flaky New Flaky Passed Skipped Wall Time Branch View
kalium-ios 0 0 0 1945 67 6m 43.1s Link
kalium-jvm 0 0 0 2255 103 14m 5s Link

@alexandreferris alexandreferris requested review from typfel, a team, gongracr, vitorhugods and ohassine and removed request for a team September 13, 2023 13:12
@vitorhugods vitorhugods changed the title feat: add archived field to conversation db (WPB-4471) chore: add archived field to conversations table (WPB-4471) Sep 13, 2023
@alexandreferris alexandreferris added this pull request to the merge queue Sep 14, 2023
Merged via the queue into develop with commit 38df69b Sep 14, 2023
@alexandreferris alexandreferris deleted the feat/add_otr_archived_to_db branch September 14, 2023 10:34
@echoes-hq echoes-hq bot added the echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. label Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. 🚨 Potential breaking changes 👕 size: L type: chore 🧹
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants