fix: message status not updated while using the fire and forget asset mechanism (WPB-4519) #2064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
… mechanism (WPB-4519) (#2061) * fix: add failure handling while remote be is offline for assests scheduler mechanism * fix: coverage * fix: coverage * fix: coverage
github-actions
bot
added
the
cherry-pick
yamilmedina
requested review from
gongracr,
Garzas,
a team,
MohamadJaara,
vitorhugods and
mchenani
and removed request for
a team
github-actions
bot
added
🚨 Potential breaking changes
👕 size: S
type: bug / fix 🐞
labels
Codecov Report
@@ Coverage Diff @@
## develop #2064 +/- ##
==========================================
Coverage 57.99% 57.99%
Complexity 24 24
==========================================
Files 1007 1007
Lines 37783 37785 +2
Branches 3430 3430
==========================================
+ Hits 21911 21913 +2
- Misses 14404 14405 +1
+ Partials 1468 1467 -1
... and 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Datadog ReportAll test runs ✅ 2 Total Test Services: 0 Failed, 0 with New Flaky, 2 Passed Test Services
|
MohamadJaara
approved these changes
Sep 15, 2023
gongracr
approved these changes
Sep 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry pick from the original PR:
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Issues
While using
ScheduleNewAssetMessageUseCaseto upload assets and the backend has the federator down (technically online but not reachable to/from by other backends) the asset is uploaded but sending the message fails not reflecting this state in the database.Causes (Optional)
No button to retry is visible, and the asset message shows as pending.
Solutions
Update the status of the message when we can't send the message with our
MessageSendFailureHandlercomponent, so can be correctly updated toFAILEDaccordingly.Testing
Test Coverage (Optional)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.