refactor: reuse okhttp instance #2065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MohamadJaara
commented
Sep 14, 2023
| } | ||
| } | ||
|
|
||
| fun OkHttpClient.Builder.ignoreAllSSLErrors(): OkHttpClient.Builder { |
There was a problem hiding this comment.
this function was creating a new builder while it was not used
MohamadJaara
requested review from
a team,
typfel,
yamilmedina,
borichellow,
Garzas and
trOnk12
and removed request for
a team
Datadog ReportAll test runs ✅ 2 Total Test Services: 0 Failed, 0 with New Flaky, 2 Passed Test Services
|
typfel
approved these changes
Sep 15, 2023
Comment on lines
73
to
75
| // OkHttp doesn't support configuring ping intervals dynamically, | ||
| // so they must be set when creating the Engine | ||
| // See https://youtrack.jetbrains.com/issue/KTOR-4752 |
There was a problem hiding this comment.
Hasn't this comment lost its context? Shouldn't it be where the pingInternval is configured.
Codecov Report
@@ Coverage Diff @@
## develop #2065 +/- ##
==========================================
Coverage 57.99% 57.99%
Complexity 24 24
==========================================
Files 1007 1007
Lines 37783 37783
Branches 3430 3430
==========================================
+ Hits 21911 21912 +1
Misses 14404 14404
+ Partials 1468 1467 -1 see 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Garzas
approved these changes
Sep 18, 2023
yamilmedina
approved these changes
Sep 18, 2023
| } | ||
| } | ||
|
|
||
| fun OkHttpClient.Builder.ignoreAllSSLErrors(): OkHttpClient.Builder { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Issues
as explained in docs okHttp client must be shared across app sessions, to reduce memory footprint and improve latency
Solutions
we already share Http engine per user session so now we share it per app
Needs releases with:
Testing
Test Coverage (Optional)
How to Test
Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.
Notes (Optional)
Specify here any other facts that you think are important for this issue.
Attachments (Optional)
Attachments like images, videos, etc. (drag and drop in the text box)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.