Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Compile testservice with Java 17 #2070

Merged
merged 1 commit into from
Sep 18, 2023
Merged

Conversation

mythsunwind
Copy link
Contributor


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Compiles the testservice with Java 17

@mythsunwind mythsunwind changed the title testservice: Compile with Java 17 fix: Compile testservice with Java 17 Sep 18, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 18, 2023

Unit Test Results

   434 files  ±0     434 suites  ±0   3m 4s ⏱️ +4s
2 361 tests ±0  2 258 ✔️ ±0  103 💤 ±0  0 ±0 

Results for commit 85d1a7d. ± Comparison against base commit 9e1f194.

♻️ This comment has been updated with latest results.

@mythsunwind mythsunwind added this pull request to the merge queue Sep 18, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #2070 (85d1a7d) into develop (9e1f194) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             develop    #2070   +/-   ##
==========================================
  Coverage      58.02%   58.02%           
  Complexity        24       24           
==========================================
  Files           1009     1009           
  Lines          37803    37803           
  Branches        3434     3434           
==========================================
  Hits           21934    21934           
  Misses         14393    14393           
  Partials        1476     1476           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e1f194...85d1a7d. Read the comment docs.

@datadog-wireapp
Copy link

Datadog Report

Branch report: testservice-java17
Commit report: 8162d08

kalium-jvm: 0 Failed, 0 New Flaky, 2258 Passed, 103 Skipped, 28m 17.01s Wall Time

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 18, 2023
@mythsunwind mythsunwind added this pull request to the merge queue Sep 18, 2023
Merged via the queue into develop with commit 846d7dd Sep 18, 2023
@mythsunwind mythsunwind deleted the testservice-java17 branch September 18, 2023 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants