Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: run some operations on worker thread #2075

Merged
merged 1 commit into from
Sep 21, 2023

Conversation

ohassine
Copy link
Member


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Some operations are detected to be run on main

Solutions

Run them om worker thread


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 20, 2023

Unit Test Results

   437 files  ±0     437 suites  ±0   2m 56s ⏱️ +23s
2 371 tests ±0  2 268 ✔️ ±0  103 💤 ±0  0 ±0 

Results for commit 0a491af. ± Comparison against base commit bf09e78.

♻️ This comment has been updated with latest results.

@datadog-wireapp
Copy link

datadog-wireapp bot commented Sep 20, 2023

Datadog Report

All test runs 43c6733 🔗

2 Total Test Services: 0 Failed, 0 with New Flaky, 2 Passed

Test Services
Service Name Failed Known Flaky New Flaky Passed Skipped Wall Time Branch View
kalium-ios 0 0 0 1633 31 10.1s Link
kalium-jvm 0 0 0 2268 103 13m 46s Link

@codecov-commenter
Copy link

Codecov Report

Merging #2075 (0a491af) into develop (bf09e78) will decrease coverage by 0.01%.
The diff coverage is 38.46%.

@@              Coverage Diff              @@
##             develop    #2075      +/-   ##
=============================================
- Coverage      57.90%   57.90%   -0.01%     
  Complexity        24       24              
=============================================
  Files           1012     1012              
  Lines          37982    37984       +2     
  Branches        3455     3455              
=============================================
+ Hits           21994    21995       +1     
- Misses         14505    14506       +1     
  Partials        1483     1483              
Files Changed Coverage Δ
...wire/kalium/logic/feature/ProteusClientProvider.kt 0.00% <0.00%> (ø)
...um/logic/feature/call/usecase/AnswerCallUseCase.kt 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf09e78...0a491af. Read the comment docs.

@ohassine ohassine added this pull request to the merge queue Sep 20, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 20, 2023
@ohassine ohassine added this pull request to the merge queue Sep 21, 2023
Merged via the queue into develop with commit 58639ea Sep 21, 2023
16 checks passed
@ohassine ohassine deleted the run_operations_on_worker_thread branch September 21, 2023 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants