Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump AVS to 9.4.12 #2077

Merged
merged 2 commits into from
Sep 22, 2023
Merged

chore: bump AVS to 9.4.12 #2077

merged 2 commits into from
Sep 22, 2023

Conversation

ohassine
Copy link
Member


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

What's new in AVS

  • Upgrade CameraX dependency to v1.2.3

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 21, 2023

Unit Test Results

   416 files   -   21     416 suites   - 21   24s ⏱️ - 1m 49s
2 274 tests  - 102  2 154 ✔️  - 119  120 💤 +17  0 ±0 

Results for commit 721b9fe. ± Comparison against base commit cb8d4af.

♻️ This comment has been updated with latest results.

@codecov-commenter
Copy link

codecov-commenter commented Sep 21, 2023

Codecov Report

Merging #2077 (721b9fe) into develop (cb8d4af) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##             develop    #2077      +/-   ##
=============================================
- Coverage      57.95%   57.94%   -0.02%     
  Complexity        24       24              
=============================================
  Files           1012     1012              
  Lines          38020    38020              
  Branches        3458     3458              
=============================================
- Hits           22036    22031       -5     
- Misses         14501    14506       +5     
  Partials        1483     1483              

see 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb8d4af...721b9fe. Read the comment docs.

@datadog-wireapp
Copy link

datadog-wireapp bot commented Sep 21, 2023

Datadog Report

All test runs 33073b6 🔗

2 Total Test Services: 0 Failed, 0 with New Flaky, 2 Passed

Test Services
Service Name Failed Known Flaky New Flaky Passed Skipped Wall Time Branch View
kalium-ios 0 0 0 2154 120 11m 4.1s Link
kalium-jvm 0 0 0 2273 103 10m 1s Link

@ohassine ohassine added this pull request to the merge queue Sep 21, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Sep 21, 2023
@ohassine ohassine added this pull request to the merge queue Sep 22, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 22, 2023
@yamilmedina yamilmedina added this pull request to the merge queue Sep 22, 2023
Merged via the queue into develop with commit 47c310d Sep 22, 2023
@yamilmedina yamilmedina deleted the bum_avs_9.4.12 branch September 22, 2023 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants