-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add flag to filter out archived conversations when fetching list [WPB-4432] #2082
feat: add flag to filter out archived conversations when fetching list [WPB-4432] #2082
Conversation
Datadog ReportAll test runs ✅ 2 Total Test Services: 0 Failed, 0 with New Flaky, 2 Passed Test Services
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just naming suggestion 😉
logic/src/commonMain/kotlin/com/wire/kalium/logic/data/conversation/ConversationRepository.kt
Outdated
Show resolved
Hide resolved
…/add_archive_flag_on_conversation_list
Codecov Report
@@ Coverage Diff @@
## develop #2082 +/- ##
==========================================
Coverage 57.94% 57.94%
Complexity 24 24
==========================================
Files 1016 1016
Lines 38104 38121 +17
Branches 3466 3469 +3
==========================================
+ Hits 22078 22089 +11
- Misses 14540 14543 +3
- Partials 1486 1489 +3
... and 3 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, just one small question 💪
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Issues
Now that we are adding user functionality to be able to archive/unarchive conversations, we are in the need of a filtering mechanism to decide whether to fetch and display the whole lot of conversations a user has, or only the non-archived ones.
Solutions
In this scenario, I decided to simply add a boolean flag on the
ObserveConversationListDetailsUseCase
since this use case is the most used one accross the app and Kalium to get the latest state of all users conversation items.Testing
Test Coverage (Optional)
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.