Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update dependencies #2085

Merged
merged 9 commits into from
Oct 2, 2023
Merged

chore: update dependencies #2085

merged 9 commits into from
Oct 2, 2023

Conversation

ohassine
Copy link
Member

@ohassine ohassine commented Sep 25, 2023


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

I am updating some dependencies to latest version
Needed for wireapp/wire-android#2266


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 25, 2023

Unit Test Results

   417 files   -   21     417 suites   - 21   24s ⏱️ - 2m 4s
2 280 tests  - 102  2 159 ✔️  - 119  121 💤 +17  0 ±0 

Results for commit d49771c. ± Comparison against base commit 0b9fab8.

♻️ This comment has been updated with latest results.

@codecov-commenter
Copy link

codecov-commenter commented Sep 25, 2023

Codecov Report

Merging #2085 (d49771c) into develop (0b9fab8) will decrease coverage by 0.01%.
Report is 1 commits behind head on develop.
The diff coverage is n/a.

@@              Coverage Diff              @@
##             develop    #2085      +/-   ##
=============================================
- Coverage      57.87%   57.87%   -0.01%     
  Complexity        24       24              
=============================================
  Files           1014     1014              
  Lines          38271    38271              
  Branches        3490     3490              
=============================================
- Hits           22151    22148       -3     
- Misses         14629    14631       +2     
- Partials        1491     1492       +1     

see 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b9fab8...d49771c. Read the comment docs.

@datadog-wireapp
Copy link

datadog-wireapp bot commented Sep 25, 2023

Datadog Report

All test runs 1f9feea 🔗

2 Total Test Services: 0 Failed, 0 with New Flaky, 2 Passed

Test Services
Service Name Failed Known Flaky New Flaky Passed Skipped Wall Time Branch View
kalium-ios 0 0 0 2161 120 10m 12.09s Link
kalium-jvm 0 0 0 2280 103 14m 46s Link

ktx-serialization = "1.5.1"
ktx-atomicfu = "0.22.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't look like an update.

Is the rollback to 0.20.0 intended?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes it's on purpose because both atomicfu 0.22 and datetime 0.4.1 duplicate this bin file

> A failure occurred while executing com.android.build.gradle.internal.tasks.MergeJavaResWorkAction
   > 2 files found with path 'META-INF/versions/9/previous-compilation-data.bin' from inputs:

I downgraded atomicfu because I recently updated it from 0.18.5

That should be fixed in 0.4.2
Kotlin/kotlinx-datetime#304

@ohassine ohassine added this pull request to the merge queue Oct 2, 2023
Merged via the queue into develop with commit f6ac4b0 Oct 2, 2023
15 checks passed
@ohassine ohassine deleted the update_dependencies branch October 2, 2023 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants