Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: network logging not getting enabled #2087

Merged
merged 1 commit into from
Sep 25, 2023

Conversation

saleniuk
Copy link
Contributor


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

RC copy of: #2030

Issues

Network logs are missing

Causes

Network logger activation is missing for CoreLogger.

Solutions

Add it back.


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@yamilmedina yamilmedina enabled auto-merge (squash) September 25, 2023 13:26
@github-actions
Copy link
Contributor

github-actions bot commented Sep 25, 2023

Unit Test Results

   429 files     429 suites   2m 43s ⏱️
2 346 tests 2 248 ✔️ 98 💤 0

Results for commit baef533.

♻️ This comment has been updated with latest results.

@datadog-wireapp
Copy link

datadog-wireapp bot commented Sep 25, 2023

Datadog Report

All test runs 228cf70 🔗

2 Total Test Services: 0 Failed, 0 with New Flaky, 2 Passed

Test Services
Service Name Failed Known Flaky New Flaky Passed Skipped Wall Time Branch View
kalium-ios 0 0 0 2131 120 10m 0s Link
kalium-jvm 0 0 0 2224 51 10m 36.05s Link

@yamilmedina yamilmedina merged commit 1888bdc into release/candidate Sep 25, 2023
12 of 13 checks passed
@yamilmedina yamilmedina deleted the fix/network-logging-RC branch September 25, 2023 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants