Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(proteus): call correct endpoint for uploading prekeys #2093

Merged
merged 1 commit into from
Sep 26, 2023

Conversation

vitorhugods
Copy link
Member


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

When uploading new prekeys, we're calling the wrong endpoint.

Causes

giphy

Solutions

Fix the path to call the correct endpoint (PUT to /client/{clientId}).

This, by itself should not cause breaking issues, but if there's any prekey rollover, it could lead to INVALID_SIGNATURE errors.

On a side note, I've added logs to the prekey generation in

Testing

Test Coverage

  • I have added automated test to this contribution

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 26, 2023

Unit Test Results

   429 files     429 suites   2m 26s ⏱️
2 346 tests 2 248 ✔️ 98 💤 0

Results for commit 1d000e7.

♻️ This comment has been updated with latest results.

@datadog-wireapp
Copy link

Datadog Report

Branch report: fix/proteus/upload-prekeys-path
Commit report: c516980

kalium-ios: 0 Failed, 0 New Flaky, 2131 Passed, 120 Skipped, 5m 35.16s Wall Time

@vitorhugods vitorhugods merged commit 5efb3eb into release/candidate Sep 26, 2023
13 checks passed
@vitorhugods vitorhugods deleted the fix/proteus/upload-prekeys-path branch September 26, 2023 10:20
github-merge-queue bot pushed a commit that referenced this pull request Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants