Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(revert): revert fix: downgrade CC to 0.8.2 and bump to 1.0.0-pre.6+v1-schemafix #2112

Closed
wants to merge 3 commits into from

Conversation

yamilmedina
Copy link
Contributor


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

We have a fix with the CC schema migration, so this PR reverts


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 4, 2023

Unit Test Results

   410 files     410 suites   22s ⏱️
2 251 tests 2 131 ✔️ 120 💤 0

Results for commit c3d398e.

♻️ This comment has been updated with latest results.

@datadog-wireapp
Copy link

datadog-wireapp bot commented Oct 4, 2023

Datadog Report

All test runs c8d8605 🔗

2 Total Test Services: 0 Failed, 0 with New Flaky, 2 Passed

Test Services
Service Name Failed Known Flaky New Flaky Passed Skipped Wall Time Branch View
kalium-ios 0 0 0 2131 120 8m 32s Link
kalium-jvm 0 0 0 2248 98 11m 11s Link

Copy link
Member

@typfel typfel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@yamilmedina yamilmedina changed the title chore(revert): revert fix: downgrade CC to 0.8.2 and bump to 1.0.0-pre.6+v1-schemafix-001 chore(revert): revert fix: downgrade CC to 0.8.2 and bump to 1.0.0-pre.6+v1-schemafix Oct 5, 2023
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (release/candidate@49c569f). Click here to learn what that means.
The diff coverage is n/a.

@@                 Coverage Diff                  @@
##             release/candidate    #2112   +/-   ##
====================================================
  Coverage                     ?   58.07%           
  Complexity                   ?       24           
====================================================
  Files                        ?     1004           
  Lines                        ?    37615           
  Branches                     ?     3433           
====================================================
  Hits                         ?    21844           
  Misses                       ?    14297           
  Partials                     ?     1474           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 49c569f...c3d398e. Read the comment docs.

@yamilmedina yamilmedina force-pushed the chore/cc-schema-migration-bump branch from aa54a47 to c3d398e Compare October 6, 2023 13:53
@yamilmedina
Copy link
Contributor Author

Closing for now as this new version is not usable at this moment.

@yamilmedina yamilmedina closed this Oct 6, 2023
@yamilmedina yamilmedina deleted the chore/cc-schema-migration-bump branch March 29, 2024 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants