-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: IntegrationTests infrastructure (WPB-4329) #2120
Merged
alexandreferris
merged 54 commits into
develop
from
feat/add_integration_tests_infrastructure
Oct 9, 2023
Merged
feat: IntegrationTests infrastructure (WPB-4329) #2120
alexandreferris
merged 54 commits into
develop
from
feat/add_integration_tests_infrastructure
Oct 9, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/add_integrartion_tests_infrastructure
…astructure' into feat/add_integrartion_tests_infrastructure
github-actions
bot
added
🚨 Potential breaking changes
type: feature ✨
👕 size: XXL
labels
Oct 9, 2023
Datadog ReportAll test runs ✅ 2 Total Test Services: 0 Failed, 0 with New Flaky, 2 Passed Test Services
|
alexandreferris
requested review from
a team,
typfel,
gongracr,
yamilmedina,
MohamadJaara and
mchenani
and removed request for
a team
October 9, 2023 13:59
mchenani
approved these changes
Oct 9, 2023
yamilmedina
approved these changes
Oct 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
This is a follow-up on #2074 (as it had to be reverted due to
HttpClientEngine
not being visible in AR`) so I have added a wrapper class for it from Kalium side.Issues
We did not have integration tests in our code base.
Causes (Optional)
It was never implemented
Solutions
Create new module
tango-tests
for integration tests.Currently it consists of:
Tests (as a POC we only have
PocIntegrationTest
) which contains only 2 tests:CommonResponses
: where it acts as an object to hold common info for tests (such as BASE_URL, and some common DTOs for now)Actions:
Login
/Client
/ACME
actions in order to provide all necessary requests/responses for specific flows so whenever we increase integration tests we don't need to copy/paste/duplicate code.Current Issue:
util
: this one we haven't managed to access the same files fromnetwork
module so for now as a POC we only duplicated those classes into this new module, but our goal is to be able to access thoseJson
mocks/values without having to duplicate them, or even have them somewhere it is easily accessible elsewhere apart from its own module.Testing
Test Coverage (Optional)
How to Test
Notes (Optional)
This is a POC to be presented in our collective, if you do have any feedback feel free to add it here and we can also discuss it later.