feat(typing): send typing indicator events use case and cleanup code pt2. (WPB-4590) #2121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd-typing-and-delete
…nd-typing-and-delete
…nd-typing-and-delete
yamilmedina
requested review from
alexandreferris,
borichellow,
ohassine and
saleniuk
and removed request for
a team
yamilmedina
changed the title
7 tasks
alexandreferris
approved these changes
Oct 9, 2023
Codecov Report
@@ Coverage Diff @@
## feat/epic-typing-indicator-sender #2121 +/- ##
=======================================================================
- Coverage 58.01% 57.94% -0.07%
Complexity 24 24
=======================================================================
Files 1024 1028 +4
Lines 38257 38321 +64
Branches 3464 3467 +3
=======================================================================
+ Hits 22193 22204 +11
- Misses 14565 14618 +53
Partials 1499 1499
... and 3 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
yamilmedina
changed the title
vitorhugods
approved these changes
Oct 10, 2023
* chore: test cov * chore: test cov * chore: test cov * chore: test cov * chore: test cov
Datadog ReportAll test runs ✅ 2 Total Test Services: 0 Failed, 0 with New Flaky, 2 Passed Test Services
|
yamilmedina
merged commit a9a31ee
into
feat/epic-typing-indicator-sender
15 checks passed
yamilmedina
added a commit
that referenced
this pull request
Oct 10, 2023
…-4590) (#2118) * fix: exclude selfuser from typingevents * fix: exclude selfuser from typingevents * fix: coverage for flag check * chore: api configuration for sending typing status * chore: api configuration for sending typing status v0 * chore: api configuration for sending typing status v0 * chore: pr comments * feat: mapper and repo ops * feat: mapper and repo ops * feat: mapper and repo ops * chore: detekt * chore: detekt * chore: tests broken * feat(typing): send typing indicator events use case and cleanup code pt2. (WPB-4590) (#2121) * feat: mapper and repo ops deletion * chore: ip * chore: some fun refactoring, just ideas * chore: some fun refactoring, just ideas * chore: some fun refactoring, just ideas * chore: working base * chore: clear indicators * chore: clear indicators * chore: clear indicators * chore: notes * chore: refactor into new classes splitted * chore: comments cleanup * chore: detekt fixes * Empty-Commit * feat(typing): send typing indicator event tests pt3. (WPB-4590) (#2122) * chore: test cov * chore: test cov * chore: test cov * chore: test cov * chore: test cov
7 tasks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 11, 2023
* feat(typing): send typing indicator events networking layer pt1. (WPB-4590) (#2118) * fix: exclude selfuser from typingevents * fix: exclude selfuser from typingevents * fix: coverage for flag check * chore: api configuration for sending typing status * chore: api configuration for sending typing status v0 * chore: api configuration for sending typing status v0 * chore: pr comments * feat: mapper and repo ops * feat: mapper and repo ops * feat: mapper and repo ops * chore: detekt * chore: detekt * chore: tests broken * feat(typing): send typing indicator events use case and cleanup code pt2. (WPB-4590) (#2121) * feat: mapper and repo ops deletion * chore: ip * chore: some fun refactoring, just ideas * chore: some fun refactoring, just ideas * chore: some fun refactoring, just ideas * chore: working base * chore: clear indicators * chore: clear indicators * chore: clear indicators * chore: notes * chore: refactor into new classes splitted * chore: comments cleanup * chore: detekt fixes * Empty-Commit * feat(typing): send typing indicator event tests pt3. (WPB-4590) (#2122) * chore: test cov * chore: test cov * chore: test cov * chore: test cov * chore: test cov * fix: not block delay, to not block send stop * feat: add missing usecase to clear reusing repository * feat: add missing usecase to clear reusing repository
echoes-hq
bot
added
the
echoes: product-roadmap
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Refactor and split repositories, and create a periodic cleanup of orphaned typing indicators, so we clean those after some time.
Needs releases with:
Testing
Test Coverage (Optional)
In the next PR, pt3.
feat(typing): send typing indicator event tests pt3. (WPB-4590) #2122
I have added automated test to this contribution
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.