fix: muting conversations when archiving / unmuting when unarchiving [WPB-5003][WPB-5004] #2123
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Issues
When we were archiving conversations, these were still triggering notifications on the notifications bar. The AC mentioned that archived conversations should not notify anything on new activity but this was not implemented.
Solutions
Upon successful archiving (remote and local) of a conversation, we will proceed to mute this conversation as well remotely and locally so that other clients also don't receive notifications on these archived ones.
The opposite will be happening to conversations that get unarchived. They will be automatically unmuted even if they were originally muted previous to the archiving event.
Testing
Test Coverage (Optional)
How to Test
Notes (Optional)
If the muting update fails either remotely or locally, we will still archive the conversation remotely. TBD if this behavior is accepted as valid to live with, or if on the contrary, we might want to revert archiving remote update if remote muting update fails.
Attachments (Optional)
Grabacion.de.pantalla.2023-10-09.a.las.16.58.21.mov
PR Post Submission Checklist for internal contributors (Optional)
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.