Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: muting conversations when archiving / unmuting when unarchiving [WPB-5003][WPB-5004] #2123

Merged
merged 3 commits into from
Oct 10, 2023

Conversation

gongracr
Copy link
Contributor

@gongracr gongracr commented Oct 9, 2023


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

When we were archiving conversations, these were still triggering notifications on the notifications bar. The AC mentioned that archived conversations should not notify anything on new activity but this was not implemented.

Solutions

Upon successful archiving (remote and local) of a conversation, we will proceed to mute this conversation as well remotely and locally so that other clients also don't receive notifications on these archived ones.

The opposite will be happening to conversations that get unarchived. They will be automatically unmuted even if they were originally muted previous to the archiving event.

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

  1. Have Alice user logged on 2 clients.
  2. Archive a conversation from Alice on client 1.
  3. Receive a message on that archived conversation from Bob.
  4. Check on client 1 and 2 that this new message didn't raise/trigger any notification on the app.

Notes (Optional)

If the muting update fails either remotely or locally, we will still archive the conversation remotely. TBD if this behavior is accepted as valid to live with, or if on the contrary, we might want to revert archiving remote update if remote muting update fails.

Attachments (Optional)

Grabacion.de.pantalla.2023-10-09.a.las.16.58.21.mov

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 9, 2023

Unit Test Results

   316 files   - 123     316 suites   - 123   9s ⏱️ - 2m 14s
1 676 tests  - 713  1 644 ✔️  - 641  32 💤  - 72  0 ±0 

Results for commit 531286d. ± Comparison against base commit 78e9b2f.

♻️ This comment has been updated with latest results.

@codecov-commenter
Copy link

codecov-commenter commented Oct 9, 2023

Codecov Report

Merging #2123 (531286d) into develop (78e9b2f) will increase coverage by 0.00%.
The diff coverage is 84.61%.

@@            Coverage Diff             @@
##             develop    #2123   +/-   ##
==========================================
  Coverage      57.97%   57.97%           
  Complexity        24       24           
==========================================
  Files           1024     1024           
  Lines          38256    38269   +13     
  Branches        3477     3478    +1     
==========================================
+ Hits           22179    22188    +9     
- Misses         14577    14580    +3     
- Partials        1500     1501    +1     
Files Coverage Δ
...rsation/UpdateConversationArchivedStatusUseCase.kt 72.72% <84.61%> (+7.72%) ⬆️

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 78e9b2f...531286d. Read the comment docs.

@datadog-wireapp
Copy link

datadog-wireapp bot commented Oct 9, 2023

Datadog Report

All test runs 8235157 🔗

2 Total Test Services: 0 Failed, 0 with New Flaky, 2 Passed

Test Services
Service Name Failed Known Flaky New Flaky Passed Skipped Wall Time Branch View
kalium-ios 0 0 0 1644 32 10.14s Link
kalium-jvm 0 0 0 2287 104 10m 13s Link

@gongracr gongracr enabled auto-merge October 10, 2023 08:17
@gongracr gongracr added this pull request to the merge queue Oct 10, 2023
Merged via the queue into develop with commit fa037c3 Oct 10, 2023
@gongracr gongracr deleted the fix/muting_archived_conversations branch October 10, 2023 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants