Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump CC to 1.0.0-rc.14 #2125

Closed
wants to merge 4 commits into from
Closed

Conversation

typfel
Copy link
Member

@typfel typfel commented Oct 10, 2023


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Bump CC to 1.0.0-rc.14

Notes

Checking if Android test pass on develop


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 10, 2023

Unit Test Results

   420 files   -   22     420 suites   - 22   23s ⏱️ - 2m 49s
2 296 tests  - 104  2 175 ✔️  - 121  121 💤 +17  0 ±0 

Results for commit 048829b. ± Comparison against base commit 675404c.

♻️ This comment has been updated with latest results.

@typfel typfel force-pushed the chore/bump-cc-1.0.0-rc.14 branch from d55674e to c134d48 Compare October 10, 2023 09:56
@codecov-commenter
Copy link

codecov-commenter commented Oct 10, 2023

Codecov Report

Merging #2125 (97a23b0) into develop (fa037c3) will decrease coverage by 0.34%.
Report is 2 commits behind head on develop.
The diff coverage is n/a.

@@              Coverage Diff              @@
##             develop    #2125      +/-   ##
=============================================
- Coverage      57.97%   57.64%   -0.34%     
  Complexity        24       24              
=============================================
  Files           1024     1031       +7     
  Lines          38269    38704     +435     
  Branches        3478     3519      +41     
=============================================
+ Hits           22188    22309     +121     
- Misses         14580    14892     +312     
- Partials        1501     1503       +2     

see 32 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa037c3...97a23b0. Read the comment docs.

@datadog-wireapp
Copy link

datadog-wireapp bot commented Oct 10, 2023

Datadog Report

All test runs 6392d69 🔗

2 Total Test Services: 0 Failed, 0 with New Flaky, 2 Passed

Test Services
Service Name Failed Known Flaky New Flaky Passed Skipped Wall Time Branch View
kalium-ios 0 0 0 2175 121 9m 49.01s Link
kalium-jvm 0 0 0 2296 104 10m 50s Link

@typfel typfel force-pushed the chore/bump-cc-1.0.0-rc.14 branch from 31e03d0 to 97a23b0 Compare October 13, 2023 08:21
@typfel typfel force-pushed the chore/bump-cc-1.0.0-rc.14 branch from 97a23b0 to 048829b Compare October 13, 2023 08:54
@typfel typfel closed this Oct 18, 2023
@typfel typfel deleted the chore/bump-cc-1.0.0-rc.14 branch October 18, 2023 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants