refactor: merge PublicUserMapper with UserMapper #2135
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Issues
I don't see any clear distinction between PublicUserMapper and UserMapper so why not merge them and have all related methods in one place.
I also tried to remove unnecessary or unused mapper methods.
fromUserProfileDtoToOtherUser
is now a composite method offromUserProfileDtoToUserEntity
andfromUserEntityToOtherUser
fromSelfUserToUserDetailsEntity
,fromSelfUserDtoToUserDetailsEntity
,fromUserProfileDtoToUserDetailsEntity
,fromFailedUserToDetailsEntity
were all removed since they were unused (we never insert UserDetailsEntity because the additional properties are computed.)fromUpdateRequestToDaoModel
withfromUpdateRequestToPartialUserEntity
, this avoids mapping from SelfUser to UserEntity.Future work
fromSelfUserToUserEntity
andfromOtherToUserEntity
is now only when importing old android scala users. If we could map directly an android scala user to a UserEntity we would complete get rid of any mapping from the model layer to to DAO.PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.