feat: search inside conversation (WPB-4915) #2137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… into feat/search_inside_conversation
# Conflicts: # logic/src/commonMain/kotlin/com/wire/kalium/logic/data/message/MessageRepository.kt # logic/src/commonTest/kotlin/com/wire/kalium/logic/data/message/MessageRepositoryTest.kt # persistence/src/commonMain/db_user/com/wire/kalium/persistence/Messages.sq # persistence/src/commonMain/kotlin/com/wire/kalium/persistence/dao/message/MessageDAO.kt # persistence/src/commonMain/kotlin/com/wire/kalium/persistence/dao/message/MessageDAOImpl.kt
Datadog ReportAll test runs ✅ 2 Total Test Services: 0 Failed, 0 with New Flaky, 2 Passed Test Services
|
alexandreferris
requested review from
a team and
typfel
and removed request for
a team
alexandreferris
requested review from
gongracr,
yamilmedina,
borichellow and
ohassine
vitorhugods
reviewed
Oct 16, 2023
There was a problem hiding this comment.
Looks solid.
Feel free to ignore my comment about pagination/performance. It's a worry I have, but I don't think it needs to be present from the beginning, and I guess it will only be proportionally slow as the search query is broad. So it's kinda expected?
Just testing the DAO tho. We should make sure the query works and will continue to work in the future.
persistence/src/commonMain/db_user/com/wire/kalium/persistence/Messages.sq
Show resolved
Hide resolved
persistence/src/commonMain/kotlin/com/wire/kalium/persistence/dao/message/MessageDAOImpl.kt
Show resolved
Hide resolved
vitorhugods
approved these changes
Oct 16, 2023
Codecov Report
@@ Coverage Diff @@
## develop #2137 +/- ##
=============================================
- Coverage 57.65% 57.54% -0.11%
Complexity 24 24
=============================================
Files 1052 1053 +1
Lines 39960 40180 +220
Branches 3725 3747 +22
=============================================
+ Hits 23038 23122 +84
- Misses 15334 15447 +113
- Partials 1588 1611 +23
... and 4 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
gongracr
approved these changes
Oct 16, 2023
6 tasks
echoes-hq
bot
added
the
echoes: product-roadmap
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Issues
There was no way to search for messages in a conversation
Causes (Optional)
Not implemented yet.
Solutions
Create usecase
GetConversationMessagesFromSearchQueryUseCaseand its respective repository and DAO functions to search for messages containing the specified search term.Testing
Test Coverage (Optional)
How to Test
Currently there is no way to test this, it will be available when AR PR is raised.