Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: schema migration #2138

Merged
merged 3 commits into from
Oct 16, 2023
Merged

fix: schema migration #2138

merged 3 commits into from
Oct 16, 2023

Conversation

typfel
Copy link
Member

@typfel typfel commented Oct 16, 2023


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 16, 2023

Unit Test Results

   429 files     429 suites   1m 58s ⏱️
2 346 tests 2 248 ✔️ 98 💤 0

Results for commit 2ad1bf8.

♻️ This comment has been updated with latest results.

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (release/candidate@49c569f). Click here to learn what that means.
The diff coverage is n/a.

@@                 Coverage Diff                  @@
##             release/candidate    #2138   +/-   ##
====================================================
  Coverage                     ?   58.06%           
  Complexity                   ?       24           
====================================================
  Files                        ?     1004           
  Lines                        ?    37615           
  Branches                     ?     3433           
====================================================
  Hits                         ?    21841           
  Misses                       ?    14300           
  Partials                     ?     1474           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 49c569f...176bb85. Read the comment docs.

@datadog-wireapp
Copy link

datadog-wireapp bot commented Oct 16, 2023

Datadog Report

All test runs 7b3c1a9 🔗

2 Total Test Services: 0 Failed, 0 with New Flaky, 2 Passed

Test Services
Service Name Failed Known Flaky New Flaky Passed Skipped Wall Time Branch View
kalium-ios 0 0 0 2131 120 11m 17s Link
kalium-jvm 0 0 0 2248 98 12m 13s Link

Copy link
Contributor

@yamilmedina yamilmedina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 🚒

@typfel typfel enabled auto-merge (squash) October 16, 2023 14:52
@typfel typfel merged commit c8abfcc into release/candidate Oct 16, 2023
12 checks passed
@typfel typfel deleted the fix/schema-migration branch October 16, 2023 15:18
github-actions bot pushed a commit that referenced this pull request Oct 16, 2023
* Revert "fix: downgrade CC to 0.8.2 to avoid migration issue (#2105)"

This reverts commit 49c569f.

* chore: bump core-crypto to 1.0.0-pre.6+v1-schemafix-003
@github-actions github-actions bot mentioned this pull request Oct 16, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants