Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove github packages repository WPB-5028 #2143

Merged
merged 2 commits into from
Oct 18, 2023

Conversation

typfel
Copy link
Member

@typfel typfel commented Oct 17, 2023


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Remove Github Packages repository since all dependencies are now on maven central.


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 17, 2023

Unit Test Results

   458 files  ±0     458 suites  ±0   3m 2s ⏱️ +37s
2 546 tests ±0  2 444 ✔️ ±0  102 💤 ±0  0 ±0 

Results for commit d5bd000. ± Comparison against base commit 8f461bc.

♻️ This comment has been updated with latest results.

@datadog-wireapp
Copy link

datadog-wireapp bot commented Oct 17, 2023

Datadog Report

All test runs 953bb99 🔗

2 Total Test Services: 0 Failed, 0 with New Flaky, 2 Passed

Test Services
Service Name Failed Known Flaky New Flaky Passed Skipped Wall Time Branch View
kalium-ios 0 0 0 2323 119 8m 21.01s Link
kalium-jvm 0 0 0 2444 102 13m 58.01s Link

@codecov-commenter
Copy link

codecov-commenter commented Oct 17, 2023

Codecov Report

Merging #2143 (d5bd000) into develop (8f461bc) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##             develop    #2143      +/-   ##
=============================================
- Coverage      57.81%   57.80%   -0.01%     
  Complexity        21       21              
=============================================
  Files           1058     1058              
  Lines          40127    40127              
  Branches        3716     3716              
=============================================
- Hits           23198    23194       -4     
- Misses         15323    15326       +3     
- Partials        1606     1607       +1     

see 4 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f461bc...d5bd000. Read the comment docs.

@typfel typfel force-pushed the chore/remove-github-packages branch from 5970721 to c610b7c Compare October 17, 2023 12:25
@typfel typfel requested review from vitorhugods, a team, alexandreferris, MohamadJaara, mchenani and saleniuk and removed request for a team October 17, 2023 12:29
@typfel typfel changed the title chore: remove github packages repository chore: remove github packages repository WPB-5028 Oct 17, 2023
@typfel typfel force-pushed the chore/remove-github-packages branch from c610b7c to d5bd000 Compare October 17, 2023 20:13
@typfel typfel enabled auto-merge October 17, 2023 20:17
@typfel typfel added this pull request to the merge queue Oct 17, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Oct 17, 2023
@typfel typfel added this pull request to the merge queue Oct 18, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Oct 18, 2023
@typfel typfel added this pull request to the merge queue Oct 18, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Oct 18, 2023
@vitorhugods vitorhugods merged commit b0f3e9a into develop Oct 18, 2023
15 checks passed
@vitorhugods vitorhugods deleted the chore/remove-github-packages branch October 18, 2023 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants