-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(events): stuck on processing calling events #2144
Merged
vitorhugods
merged 3 commits into
release/candidate
from
fix/events/stuck-on-processing-calling-events
Oct 17, 2023
Merged
fix(events): stuck on processing calling events #2144
vitorhugods
merged 3 commits into
release/candidate
from
fix/events/stuck-on-processing-calling-events
Oct 17, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vitorhugods
requested review from
a team,
typfel,
alexandreferris,
MohamadJaara,
mchenani and
saleniuk
and removed request for
a team
October 17, 2023 14:51
ohassine
approved these changes
Oct 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🕵️🕵️
alexandreferris
approved these changes
Oct 17, 2023
yamilmedina
approved these changes
Oct 17, 2023
Datadog ReportAll test runs ✅ 2 Total Test Services: 0 Failed, 0 with New Flaky, 2 Passed Test Services
|
5 tasks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 17, 2023
* fix(events): stuck on processing calling events (#2144) * ci: trigger build --------- Co-authored-by: Vitor Hugo Schwaab <[email protected]>
vitorhugods
added a commit
that referenced
this pull request
Oct 18, 2023
(cherry picked from commit 3f6584a)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Issues
Some users are stuck in
Waiting for Connection
orDecrypting Messages
for ever.Causes
If there's any error while we're fetching AVS Config, we don't ever let AVS know, and it will forever keep waiting for the configs.
Solutions
Let AVS know that there has been an error. AVS will eventually (every 60s) ask us to try again.
Testing
Tested manually by changing the success code to also simulate an error and check that AVS asks us to try again.
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.