Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(events): stuck on processing calling events #2144

Merged

Conversation

vitorhugods
Copy link
Member


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Some users are stuck in Waiting for Connection or Decrypting Messages for ever.

Causes

If there's any error while we're fetching AVS Config, we don't ever let AVS know, and it will forever keep waiting for the configs.

Solutions

Let AVS know that there has been an error. AVS will eventually (every 60s) ask us to try again.

Note
In the future we can make our own retry mechanism for calling config, so it can be more responsive than just "once every 60s".

Testing

Tested manually by changing the success code to also simulate an error and check that AVS asks us to try again.


PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

Copy link
Member

@ohassine ohassine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🕵️🕵️

@vitorhugods vitorhugods enabled auto-merge (squash) October 17, 2023 14:58
@github-actions
Copy link
Contributor

github-actions bot commented Oct 17, 2023

Unit Test Results

   412 files     412 suites   24s ⏱️
2 260 tests 2 140 ✔️ 120 💤 0

Results for commit 92d9a9e.

♻️ This comment has been updated with latest results.

@datadog-wireapp
Copy link

datadog-wireapp bot commented Oct 17, 2023

Datadog Report

All test runs 80b76ef 🔗

2 Total Test Services: 0 Failed, 0 with New Flaky, 2 Passed

Test Services
Service Name Failed Known Flaky New Flaky Passed Skipped Wall Time Branch View
kalium-ios 0 0 0 2140 120 5m 58s Link
kalium-jvm 0 0 0 2257 98 12m 39s Link

@vitorhugods vitorhugods disabled auto-merge October 17, 2023 15:58
@vitorhugods vitorhugods merged commit 3f6584a into release/candidate Oct 17, 2023
5 checks passed
@vitorhugods vitorhugods deleted the fix/events/stuck-on-processing-calling-events branch October 17, 2023 15:58
github-merge-queue bot pushed a commit that referenced this pull request Oct 17, 2023
* fix(events): stuck on processing calling events (#2144)

* ci: trigger build

---------

Co-authored-by: Vitor Hugo Schwaab <[email protected]>
vitorhugods added a commit that referenced this pull request Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants