Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: make objects into data objects (RC) #2146

Merged

Conversation

vitorhugods
Copy link
Member


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

It's annoying to read minified logs of object that are used mainly as data classes.

Causes

These classes are minified and become jiberish unles we ReTrace them.

Solutions

Rely on Kotlin's data object for them


PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

Copy link
Contributor

@yamilmedina yamilmedina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RC ? 😅 Perhaps too brave to not test it more in development, just because "in case of"

Nevertheless, amazing job, always keeping the code up to date.

@vitorhugods
Copy link
Member Author

RC ? 😅 Perhaps too brave to not test it more in development, just because "in case of"

Nevertheless, amazing job, always keeping the code up to date.

I don't think it can hurt in any way. I was actually thinking it would be benefitial to have better logs from RC for the next release :D

@github-actions
Copy link
Contributor

github-actions bot commented Oct 17, 2023

Unit Test Results

   431 files     431 suites   2m 37s ⏱️
2 355 tests 2 257 ✔️ 98 💤 0

Results for commit 9927971.

♻️ This comment has been updated with latest results.

@datadog-wireapp
Copy link

datadog-wireapp bot commented Oct 17, 2023

Datadog Report

All test runs a4f1c0f 🔗

2 Total Test Services: 0 Failed, 0 with New Flaky, 2 Passed

Test Services
Service Name Failed Known Flaky New Flaky Passed Skipped Wall Time Branch View
kalium-ios 0 0 0 2140 120 7m 37s Link
kalium-jvm 0 0 0 2257 98 21m 5.01s Link

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (release/candidate@3f6584a). Click here to learn what that means.
The diff coverage is n/a.

@@                 Coverage Diff                  @@
##             release/candidate    #2146   +/-   ##
====================================================
  Coverage                     ?   58.14%           
  Complexity                   ?       21           
====================================================
  Files                        ?     1010           
  Lines                        ?    37711           
  Branches                     ?     3434           
====================================================
  Hits                         ?    21928           
  Misses                       ?    14312           
  Partials                     ?     1471           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f6584a...9927971. Read the comment docs.

@yamilmedina yamilmedina self-requested a review October 17, 2023 20:28
Copy link
Contributor

@yamilmedina yamilmedina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let go then 🚀 🇲🇬

@vitorhugods vitorhugods enabled auto-merge (squash) October 17, 2023 20:39
@vitorhugods vitorhugods merged commit 2d2f00f into release/candidate Oct 18, 2023
13 checks passed
@vitorhugods vitorhugods deleted the chore/logging/make-objects-into-data-objects branch October 18, 2023 06:36
github-actions bot pushed a commit that referenced this pull request Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants