-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: make objects into data objects (RC) #2146
chore: make objects into data objects (RC) #2146
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RC ? 😅 Perhaps too brave to not test it more in development, just because "in case of"
Nevertheless, amazing job, always keeping the code up to date.
I don't think it can hurt in any way. I was actually thinking it would be benefitial to have better logs from RC for the next release :D |
Datadog ReportAll test runs ✅ 2 Total Test Services: 0 Failed, 0 with New Flaky, 2 Passed Test Services
|
Codecov Report
@@ Coverage Diff @@
## release/candidate #2146 +/- ##
====================================================
Coverage ? 58.14%
Complexity ? 21
====================================================
Files ? 1010
Lines ? 37711
Branches ? 3434
====================================================
Hits ? 21928
Misses ? 14312
Partials ? 1471 Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let go then 🚀 🇲🇬
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Issues
It's annoying to read minified logs of
object
that are used mainly as data classes.Causes
These classes are minified and become jiberish unles we ReTrace them.
Solutions
Rely on Kotlin's
data object
for themPR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.