Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: make objects into data objects #2147

Merged
merged 2 commits into from
Oct 17, 2023

Conversation

vitorhugods
Copy link
Member


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

It's annoying to read minified logs of object that are used mainly as data classes.

Causes

These classes are minified and become jiberish unles we ReTrace them.

Solutions

Rely on Kotlin's data object for them


PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 17, 2023

Unit Test Results

   458 files  ±0     458 suites  ±0   2m 21s ⏱️ -1s
2 546 tests ±0  2 444 ✔️ ±0  102 💤 ±0  0 ±0 

Results for commit 7f60bae. ± Comparison against base commit a3963e9.

♻️ This comment has been updated with latest results.

@codecov-commenter
Copy link

Codecov Report

Merging #2147 (7f60bae) into develop (a3963e9) will decrease coverage by 0.01%.
The diff coverage is 75.69%.

@@              Coverage Diff              @@
##             develop    #2147      +/-   ##
=============================================
- Coverage      57.82%   57.81%   -0.01%     
  Complexity        21       21              
=============================================
  Files           1058     1058              
  Lines          40123    40123              
  Branches        3716     3716              
=============================================
- Hits           23200    23198       -2     
- Misses         15315    15319       +4     
+ Partials        1608     1606       -2     
Files Coverage Δ
...re/kalium/logic/configuration/FileSharingStatus.kt 100.00% <ø> (ø)
...ire/kalium/logic/data/conversation/Conversation.kt 90.85% <100.00%> (-1.83%) ⬇️
...lium/logic/data/conversation/ConversationStatus.kt 80.00% <100.00%> (ø)
...tlin/com/wire/kalium/logic/data/message/Message.kt 49.30% <100.00%> (-0.70%) ⬇️
...lium/logic/data/publicuser/SearchUserRepository.kt 84.41% <100.00%> (ø)
...re/kalium/logic/data/sync/IncrementalSyncStatus.kt 100.00% <ø> (ø)
.../com/wire/kalium/logic/data/sync/SlowSyncStatus.kt 100.00% <ø> (ø)
...otlin/com/wire/kalium/logic/data/sync/SyncState.kt 100.00% <100.00%> (ø)
.../com/wire/kalium/logic/data/web/WebEventContent.kt 28.22% <100.00%> (ø)
...m/wire/kalium/logic/failure/ServerConfigFailure.kt 100.00% <100.00%> (ø)
... and 93 more

... and 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a3963e9...7f60bae. Read the comment docs.

@datadog-wireapp
Copy link

Datadog Report

All test runs 0873350 🔗

2 Total Test Services: 0 Failed, 0 with New Flaky, 2 Passed

Test Services
Service Name Failed Known Flaky New Flaky Passed Skipped Wall Time Branch View
kalium-ios 0 0 0 2287 78 7m 51.24s Link
kalium-jvm 0 0 0 2444 102 17m 9s Link

@vitorhugods vitorhugods added this pull request to the merge queue Oct 17, 2023
Merged via the queue into develop with commit 8f461bc Oct 17, 2023
16 checks passed
@vitorhugods vitorhugods deleted the chore/make-objects-into-data-objects branch October 17, 2023 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants