-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: make objects into data objects #2147
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #2147 +/- ##
=============================================
- Coverage 57.82% 57.81% -0.01%
Complexity 21 21
=============================================
Files 1058 1058
Lines 40123 40123
Branches 3716 3716
=============================================
- Hits 23200 23198 -2
- Misses 15315 15319 +4
+ Partials 1608 1606 -2
... and 3 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Datadog ReportAll test runs ✅ 2 Total Test Services: 0 Failed, 0 with New Flaky, 2 Passed Test Services
|
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Issues
It's annoying to read minified logs of
object
that are used mainly as data classes.Causes
These classes are minified and become jiberish unles we ReTrace them.
Solutions
Rely on Kotlin's
data object
for themPR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.