Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove unused code #2149

Merged
merged 5 commits into from
Oct 18, 2023
Merged

chore: remove unused code #2149

merged 5 commits into from
Oct 18, 2023

Conversation

vitorhugods
Copy link
Member


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Some of the code in UserSessionScope was completely unused.

Solutions

🧹🗑️♻️


PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@vitorhugods vitorhugods requested review from a team, typfel, alexandreferris, MohamadJaara, mchenani and saleniuk and removed request for a team October 18, 2023 10:33
@vitorhugods vitorhugods enabled auto-merge October 18, 2023 12:15
@github-actions
Copy link
Contributor

github-actions bot commented Oct 18, 2023

Unit Test Results

0 files   -    458  0 suites   - 458   0s ⏱️ - 3m 14s
0 tests  - 2 550  0 ✔️  - 2 448  0 💤  - 102  0 ±0 

Results for commit 23ebed9. ± Comparison against base commit c679750.

♻️ This comment has been updated with latest results.

@datadog-wireapp
Copy link

datadog-wireapp bot commented Oct 18, 2023

Datadog Report

All test runs 349d848 🔗

2 Total Test Services: 0 Failed, 0 with New Flaky, 2 Passed

Test Services
Service Name Failed Known Flaky New Flaky Passed Skipped Wall Time Branch View
kalium-ios 0 0 0 1769 30 10.1s Link
kalium-jvm 0 0 0 2448 102 14m 40s Link

@vitorhugods vitorhugods added this pull request to the merge queue Oct 18, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #2149 (241354f) into develop (c82d8aa) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##             develop    #2149      +/-   ##
=============================================
- Coverage      57.82%   57.81%   -0.01%     
  Complexity        21       21              
=============================================
  Files           1058     1058              
  Lines          40142    40142              
  Branches        3719     3719              
=============================================
- Hits           23211    23209       -2     
- Misses         15325    15326       +1     
- Partials        1606     1607       +1     

see 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c82d8aa...241354f. Read the comment docs.

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 18, 2023
@yamilmedina yamilmedina merged commit 91223ab into develop Oct 18, 2023
7 checks passed
@yamilmedina yamilmedina deleted the chore/cleanup-unused-code branch October 18, 2023 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants