Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: new conversation started unverified warning system message (WPB-2266) #2163

Merged
merged 11 commits into from
Oct 24, 2023

Conversation

yamilmedina
Copy link
Contributor

@yamilmedina yamilmedina commented Oct 23, 2023

StoryWPB-2266 Android Unverified user warning on connection request and in-chat


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

We need to provide a warning to a user on connection request and in-chat to warn them to beware of whom they trust or share sensitive information with on wire.

Causes

Not implemented.

Solution

  • Add a warning for connection requests (sending and receiving) to/from an unverified user.
  • Add an initial system message when creating, starting a conversation, so they are aware that there might be unverified users.

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 23, 2023

Unit Test Results

   459 files  ±0     459 suites  ±0   2m 8s ⏱️ - 1m 18s
2 558 tests +2  2 454 ✔️ +2  104 💤 ±0  0 ±0 

Results for commit 389e100. ± Comparison against base commit 872981a.

♻️ This comment has been updated with latest results.

@codecov-commenter
Copy link

codecov-commenter commented Oct 23, 2023

Codecov Report

Merging #2163 (389e100) into develop (872981a) will increase coverage by 0.00%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##             develop    #2163   +/-   ##
==========================================
  Coverage      57.88%   57.89%           
  Complexity        21       21           
==========================================
  Files           1059     1059           
  Lines          40190    40230   +40     
  Branches        3722     3730    +8     
==========================================
+ Hits           23265    23292   +27     
- Misses         15314    15327   +13     
  Partials        1611     1611           
Files Coverage Δ
...c/data/conversation/ConversationGroupRepository.kt 97.65% <100.00%> (+0.04%) ⬆️
...ation/NewGroupConversationSystemMessagesCreator.kt 91.81% <100.00%> (+0.90%) ⬆️
...ature/connection/AcceptConnectionRequestUseCase.kt 100.00% <100.00%> (ø)
...re/kalium/logic/sync/receiver/UserEventReceiver.kt 82.25% <100.00%> (+0.59%) ⬆️
...ceiver/conversation/NewConversationEventHandler.kt 89.65% <100.00%> (+0.36%) ⬆️
...re/kalium/persistence/dao/message/MessageEntity.kt 77.50% <100.00%> (+0.09%) ⬆️
...m/wire/kalium/logic/data/message/MessageContent.kt 41.01% <50.00%> (+0.08%) ⬆️
...kalium/logic/data/message/PersistMessageUseCase.kt 0.00% <0.00%> (ø)
...tlin/com/wire/kalium/logic/data/message/Message.kt 48.95% <0.00%> (-0.35%) ⬇️
.../persistence/dao/message/MessageInsertExtension.kt 74.44% <33.33%> (-0.47%) ⬇️
... and 3 more

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 872981a...389e100. Read the comment docs.

@datadog-wireapp
Copy link

datadog-wireapp bot commented Oct 23, 2023

Datadog Report

All test runs d7bf8c1 🔗

2 Total Test Services: 0 Failed, 0 with New Flaky, 2 Passed

Test Services
Service Name Failed Known Flaky New Flaky Passed Skipped Wall Time Branch View
kalium-ios 0 0 0 2134 66 9m 40.11s Link
kalium-jvm 0 0 0 2454 104 26m 53s Link

@yamilmedina yamilmedina marked this pull request as ready for review October 24, 2023 09:44
@yamilmedina yamilmedina requested review from Garzas, alexandreferris, a team, MohamadJaara, vitorhugods and saleniuk and removed request for a team October 24, 2023 09:44
@yamilmedina yamilmedina changed the title feat: connection request warning badge (WPB-2266) feat: connection request warning system message (WPB-2266) Oct 24, 2023
@yamilmedina yamilmedina changed the title feat: connection request warning system message (WPB-2266) feat: connection request and new conversation unverified warning system message (WPB-2266) Oct 24, 2023
@yamilmedina yamilmedina changed the title feat: connection request and new conversation unverified warning system message (WPB-2266) feat: new conversation started unverified warning system message (WPB-2266) Oct 24, 2023
@yamilmedina yamilmedina enabled auto-merge October 24, 2023 11:55
@yamilmedina yamilmedina added this pull request to the merge queue Oct 24, 2023
Merged via the queue into develop with commit 85418fc Oct 24, 2023
@yamilmedina yamilmedina deleted the feat/connection-req-warning-badge branch October 24, 2023 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants