-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: paginating fetch multiple users request [WPB-4999] #2165
Conversation
* fix: paginating fetch multiple users request [WPB-4999] * fix logs to print only sizes * fix imports * add tests
Codecov Report
@@ Coverage Diff @@
## develop #2165 +/- ##
==========================================
Coverage 57.97% 57.97%
Complexity 21 21
==========================================
Files 1064 1064
Lines 40309 40319 +10
Branches 3733 3733
==========================================
+ Hits 23368 23376 +8
- Misses 15329 15330 +1
- Partials 1612 1613 +1
... and 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Datadog ReportAll test runs ✅ 2 Total Test Services: 0 Failed, 0 with New Flaky, 2 Passed Test Services
|
Cherry pick from the original PR:
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Issues
Currently when the app needs to fetch multiple users details, it makes a single request with all userIds. When the list contains around 4000 items, the API returns 413 Content Too Large.
Solutions
Make this request paginated.
Testing
Test Coverage (Optional)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.