Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update core crypto to latest version #2168

Merged
merged 3 commits into from
Oct 30, 2023

Conversation

augustocdias
Copy link
Contributor


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Updates Core Crypto to latest version so it is compatible with web.


References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 25, 2023

Unit Test Results

   463 files     463 suites   2m 13s ⏱️
2 587 tests 2 483 ✔️ 104 💤 0

Results for commit 96d76cc.

♻️ This comment has been updated with latest results.

@codecov-commenter
Copy link

codecov-commenter commented Oct 25, 2023

Codecov Report

Merging #2168 (14ea329) into develop (872981a) will increase coverage by 0.03%.
Report is 7 commits behind head on develop.
The diff coverage is 75.36%.

@@              Coverage Diff              @@
##             develop    #2168      +/-   ##
=============================================
+ Coverage      57.88%   57.92%   +0.03%     
  Complexity        21       21              
=============================================
  Files           1059     1064       +5     
  Lines          40190    40283      +93     
  Branches        3722     3733      +11     
=============================================
+ Hits           23265    23333      +68     
- Misses         15314    15337      +23     
- Partials        1611     1613       +2     
Files Coverage Δ
...c/data/conversation/ConversationGroupRepository.kt 97.65% <100.00%> (+0.04%) ⬆️
...ation/NewGroupConversationSystemMessagesCreator.kt 91.81% <100.00%> (+0.90%) ⬆️
...ature/connection/AcceptConnectionRequestUseCase.kt 100.00% <100.00%> (ø)
...ire/kalium/logic/feature/e2ei/CertificateStatus.kt 100.00% <100.00%> (ø)
.../wire/kalium/logic/feature/e2ei/E2eiCertificate.kt 100.00% <100.00%> (ø)
...um/logic/feature/e2ei/usecase/EnrollE2EIUseCase.kt 100.00% <ø> (ø)
.../feature/e2ei/usecase/GetE2EICertificateUseCase.kt 100.00% <100.00%> (ø)
...re/kalium/logic/sync/receiver/UserEventReceiver.kt 82.25% <100.00%> (+0.59%) ⬆️
...ceiver/conversation/NewConversationEventHandler.kt 89.65% <100.00%> (+0.36%) ⬆️
...otlin/com/wire/kalium/logic/util/E2eiExtensions.kt 100.00% <100.00%> (ø)
... and 13 more

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 898cc8a...14ea329. Read the comment docs.

@augustocdias augustocdias marked this pull request as ready for review October 25, 2023 11:27
@datadog-wireapp
Copy link

datadog-wireapp bot commented Oct 25, 2023

Datadog Report

All test runs 7bc241e 🔗

❄️ 2 Total Test Services: 0 Failed, 1 with New Flaky, 2 Passed

Test Services
Service Name Failed Known Flaky New Flaky Passed Skipped Wall Time Branch View
kalium-jvm 0 0 1 2483 104 54m 37.01s Link
kalium-ios 0 0 0 2360 119 10m 2.08s Link

@augustocdias augustocdias added this pull request to the merge queue Oct 30, 2023
Merged via the queue into develop with commit 033a8ff Oct 30, 2023
15 checks passed
@augustocdias augustocdias deleted the chore/update-cc branch October 30, 2023 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants