Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: cherry pick improvements #2171

Merged
merged 2 commits into from
Oct 26, 2023

Conversation

Garzas
Copy link
Contributor

@Garzas Garzas commented Oct 25, 2023


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Cherry pick from #2115

@github-actions
Copy link
Contributor

github-actions bot commented Oct 25, 2023

Unit Test Results

   412 files     412 suites   22s ⏱️
2 262 tests 2 142 ✔️ 120 💤 0

Results for commit 4ea75f4.

♻️ This comment has been updated with latest results.

@datadog-wireapp
Copy link

datadog-wireapp bot commented Oct 25, 2023

Datadog Report

All test runs 452b849 🔗

2 Total Test Services: 0 Failed, 0 with New Flaky, 2 Passed

Test Services
Service Name Failed Known Flaky New Flaky Passed Skipped Wall Time Branch View
kalium-ios 0 0 0 2142 120 9m 8s Link
kalium-jvm 0 0 0 2259 98 12m 48s Link

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (release/candidate@7603587). Click here to learn what that means.
The diff coverage is n/a.

@@                 Coverage Diff                  @@
##             release/candidate    #2171   +/-   ##
====================================================
  Coverage                     ?   58.16%           
  Complexity                   ?       21           
====================================================
  Files                        ?     1010           
  Lines                        ?    37721           
  Branches                     ?     3434           
====================================================
  Hits                         ?    21939           
  Misses                       ?    14311           
  Partials                     ?     1471           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7603587...69223b6. Read the comment docs.

@Garzas Garzas enabled auto-merge (squash) October 26, 2023 08:20
@Garzas Garzas merged commit 5f7e64e into release/candidate Oct 26, 2023
12 checks passed
@Garzas Garzas deleted the feat/cherry-pick-improvements-rc branch October 26, 2023 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants