Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(sync): bump slow sync version (WPB-5057) #2174

Merged
merged 2 commits into from
Oct 27, 2023

Conversation

github-actions[bot]
Copy link
Contributor

Cherry pick from the original PR:


⚠️ Conflicts during cherry-pick:
logic/src/commonMain/kotlin/com/wire/kalium/logic/sync/slow/SlowSyncManager.kt

Now that fetching of users is paginated and errors in this step are properly propagated, we should perform sync again to cover affected users.


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Now that fetching users is being paginated

Users in huge teams (1000+ users) can properly fetch all contacts during slow sync. But #2158 doesn't trigger slow sync again.

Solutions

Bump the SlowSync Version, so Kalium will trigger it again after updating the app.

Also, move it to be private inside the class, as there's no reason to make it publicly available like it was before.


PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@github-actions github-actions bot added the cherry-pick PR is cherry-picking changes from another banch label Oct 26, 2023
Develop was bumped to 5, and RC also was bumped to 5. We need to make Develop to 6 so it will trigger an update on the next release from develop.
@vitorhugods vitorhugods enabled auto-merge October 26, 2023 13:39
@vitorhugods vitorhugods requested review from a team, typfel, gongracr, borichellow, vitorhugods and mchenani and removed request for a team October 26, 2023 13:39
@github-actions
Copy link
Contributor Author

github-actions bot commented Oct 26, 2023

Unit Test Results

   463 files  ±0     463 suites  ±0   2m 19s ⏱️ - 1m 15s
2 578 tests ±0  2 474 ✔️ ±0  104 💤 ±0  0 ±0 

Results for commit 00bec2c. ± Comparison against base commit 2fb391f.

♻️ This comment has been updated with latest results.

@vitorhugods vitorhugods requested review from tmspzz, Garzas and saleniuk and removed request for gongracr October 26, 2023 14:01
@datadog-wireapp
Copy link

datadog-wireapp bot commented Oct 26, 2023

Datadog Report

All test runs 4348753 🔗

2 Total Test Services: 0 Failed, 0 with New Flaky, 2 Passed

Test Services
Service Name Failed Known Flaky New Flaky Passed Skipped Wall Time Branch View
kalium-ios 0 0 0 1787 30 9.09s Link
kalium-jvm 0 0 0 2474 104 25m 19s Link

@codecov-commenter
Copy link

Codecov Report

Merging #2174 (00bec2c) into develop (2fb391f) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##             develop    #2174      +/-   ##
=============================================
- Coverage      57.98%   57.97%   -0.01%     
  Complexity        21       21              
=============================================
  Files           1064     1064              
  Lines          40319    40319              
  Branches        3733     3733              
=============================================
- Hits           23377    23375       -2     
- Misses         15330    15332       +2     
  Partials        1612     1612              
Files Coverage Δ
...com/wire/kalium/logic/sync/slow/SlowSyncManager.kt 94.11% <ø> (ø)

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2fb391f...00bec2c. Read the comment docs.

@vitorhugods vitorhugods added this pull request to the merge queue Oct 27, 2023
Merged via the queue into develop with commit 9d54a5b Oct 27, 2023
15 checks passed
@vitorhugods vitorhugods deleted the chore/bump-slow-sync-version-cherry-pick branch October 27, 2023 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick PR is cherry-picking changes from another banch 👕 size: S type: chore 🧹
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants