-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(sync): bump slow sync version (WPB-5057) #2174
chore(sync): bump slow sync version (WPB-5057) #2174
Conversation
Develop was bumped to 5, and RC also was bumped to 5. We need to make Develop to 6 so it will trigger an update on the next release from develop.
Datadog ReportAll test runs ✅ 2 Total Test Services: 0 Failed, 0 with New Flaky, 2 Passed Test Services
|
Codecov Report
@@ Coverage Diff @@
## develop #2174 +/- ##
=============================================
- Coverage 57.98% 57.97% -0.01%
Complexity 21 21
=============================================
Files 1064 1064
Lines 40319 40319
Branches 3733 3733
=============================================
- Hits 23377 23375 -2
- Misses 15330 15332 +2
Partials 1612 1612
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Cherry pick from the original PR:
logic/src/commonMain/kotlin/com/wire/kalium/logic/sync/slow/SlowSyncManager.kt
Now that fetching of users is paginated and errors in this step are properly propagated, we should perform sync again to cover affected users.
PR Submission Checklist for internal contributors
The PR Title
The PR Description
What's new in this PR?
Issues
Now that fetching users is being paginated
Users in huge teams (1000+ users) can properly fetch all contacts during slow sync. But #2158 doesn't trigger slow sync again.
Solutions
Bump the SlowSync Version, so Kalium will trigger it again after updating the app.
Also, move it to be private inside the class, as there's no reason to make it publicly available like it was before.
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.