Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: create observer for team app lock config (WPB-4476) #2175

Merged
merged 7 commits into from
Nov 1, 2023

Conversation

ohassine
Copy link
Member

@ohassine ohassine commented Oct 27, 2023


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Description

A use case created to be used by clients to observe team app lock config.


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@ohassine ohassine requested review from a team, typfel, gongracr, borichellow, vitorhugods and saleniuk and removed request for a team October 27, 2023 10:21
@ohassine ohassine changed the title feat: use case for observing team app lock config (WPB-4476) feat: create observer for team app lock config (WPB-4476) Oct 27, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 27, 2023

Unit Test Results

   464 files  +1     464 suites  +1   3m 9s ⏱️ -12s
2 589 tests +2  2 485 ✔️ +2  104 💤 ±0  0 ±0 

Results for commit 689318d. ± Comparison against base commit 033a8ff.

♻️ This comment has been updated with latest results.

@datadog-wireapp
Copy link

datadog-wireapp bot commented Oct 27, 2023

Datadog Report

All test runs a4fc982 🔗

2 Total Test Services: 0 Failed, 0 with New Flaky, 2 Passed

Test Services
Service Name Failed Known Flaky New Flaky Passed Skipped Wall Time Branch View
kalium-ios 0 0 0 1792 30 10.09s Link
kalium-jvm 0 0 0 2485 104 23m 19s Link

@codecov-commenter
Copy link

codecov-commenter commented Oct 30, 2023

Codecov Report

Merging #2175 (689318d) into develop (033a8ff) will decrease coverage by 0.02%.
The diff coverage is 33.33%.

@@              Coverage Diff              @@
##             develop    #2175      +/-   ##
=============================================
- Coverage      57.98%   57.97%   -0.02%     
  Complexity        21       21              
=============================================
  Files           1063     1065       +2     
  Lines          40447    40472      +25     
  Branches        3737     3739       +2     
=============================================
+ Hits           23455    23463       +8     
- Misses         15380    15396      +16     
- Partials        1612     1613       +1     
Files Coverage Δ
.../kalium/logic/feature/applock/AppLockTeamConfig.kt 100.00% <100.00%> (ø)
...eature/applock/AppLockTeamFeatureConfigObserver.kt 100.00% <100.00%> (ø)
.../logic/sync/receiver/FeatureConfigEventReceiver.kt 59.52% <50.00%> (ø)
...in/com/wire/kalium/logic/data/event/EventMapper.kt 16.62% <0.00%> (-0.23%) ⬇️
...n/kotlin/com/wire/kalium/logic/data/event/Event.kt 80.59% <0.00%> (-1.54%) ⬇️

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 033a8ff...689318d. Read the comment docs.

@ohassine ohassine added this pull request to the merge queue Nov 1, 2023
Merged via the queue into develop with commit bfcae0a Nov 1, 2023
15 checks passed
@ohassine ohassine deleted the observe_team_app_lock_config branch November 1, 2023 06:33
@echoes-hq echoes-hq bot added the echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. label Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. 🚨 Potential breaking changes 👕 size: M type: feature ✨
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants