Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Conversation proteus verification #2178

Merged
merged 4 commits into from
Nov 6, 2023

Conversation

borichellow
Copy link
Contributor

What's new in this PR?

Issues

  1. verification statuses of "my" clients were ignored in calculating conversation verification status
  2. Conversation verification status was not affected after adding/removing members into the conversation
  3. when the new group conversation is created it automatically gets a system message that the conversation verification was degraded.

Causes (Optional)

  1. not implemented
  2. not implemented
  3. didn't know it's an issue

Solutions

  1. implement it by checking "my clients" in calculating the conversations verification status (ignore 1 clients status, as it's my current client)
  2. add trigger for members changes, to re-calculate conversation status
  3. update addMessageAfterProteusVerificationStatusChange trigger to work only if new or prev status is VERIFIED, so trigger doesn't run when status changes : not_verified -> degraded.

@CLAassistant
Copy link

CLAassistant commented Oct 31, 2023

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

github-actions bot commented Oct 31, 2023

Unit Test Results

   382 files   -   82     382 suites   - 82   26s ⏱️ - 4m 5s
2 227 tests  - 362  2 161 ✔️  - 324  66 💤  - 38  0 ±0 

Results for commit fcd8396. ± Comparison against base commit bfcae0a.

♻️ This comment has been updated with latest results.

@datadog-wireapp
Copy link

datadog-wireapp bot commented Oct 31, 2023

Datadog Report

All test runs 13e8b9e 🔗

2 Total Test Services: 0 Failed, 0 with New Flaky, 2 Passed

Test Services
Service Name Failed Known Flaky New Flaky Passed Skipped Wall Time Branch View
kalium-ios 0 0 0 2161 66 5m 44.08s Link
kalium-jvm 0 0 0 2485 104 11m 41s Link

@borichellow borichellow added this pull request to the merge queue Nov 6, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 6, 2023
@borichellow borichellow added this pull request to the merge queue Nov 6, 2023
Merged via the queue into develop with commit 021f22f Nov 6, 2023
15 checks passed
@borichellow borichellow deleted the fix/conversation_proteus_verification branch November 6, 2023 10:36
augustocdias pushed a commit that referenced this pull request Nov 9, 2023
* fix: Conversation Proteus verification

* Fixed test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants