Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disable status update for private users #2202

Merged
merged 14 commits into from
Nov 14, 2023

Conversation

MohamadJaara
Copy link
Member


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

private users have the ability to change status

Causes (Optional)

an over sight from our side since this feature will not work (server side) for private users

Solutions

UI: remove the option to change the status
Kalium: add logic that can run after slow sync to reset the status locally to none

Dependencies (Optional)

If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

Copy link
Contributor

github-actions bot commented Nov 8, 2023

Unit Test Results

   342 files   - 128     342 suites   - 128   12s ⏱️ - 2m 26s
1 852 tests  - 772  1 822 ✔️  - 698  30 💤  - 74  0 ±0 

Results for commit e7f96d6. ± Comparison against base commit cdf5567.

♻️ This comment has been updated with latest results.

@datadog-wireapp
Copy link

datadog-wireapp bot commented Nov 8, 2023

Datadog Report

All test runs 0eda453 🔗

2 Total Test Services: 0 Failed, 0 with New Flaky, 2 Passed

Test Services
Service Name Failed Known Flaky New Flaky Passed Skipped Wall Time Branch View
kalium-ios 0 0 0 1822 30 13s Link
kalium-jvm 0 0 0 2527 104 7m 23.06s Link

@MohamadJaara MohamadJaara marked this pull request as ready for review November 8, 2023 16:21
@codecov-commenter
Copy link

codecov-commenter commented Nov 9, 2023

Codecov Report

Merging #2202 (53d1af5) into develop (b1cb22e) will increase coverage by 0.02%.
The diff coverage is 90.00%.

@@              Coverage Diff              @@
##             develop    #2202      +/-   ##
=============================================
+ Coverage      58.02%   58.04%   +0.02%     
  Complexity        21       21              
=============================================
  Files           1070     1073       +3     
  Lines          40701    40737      +36     
  Branches        3766     3770       +4     
=============================================
+ Hits           23617    23647      +30     
- Misses         15465    15469       +4     
- Partials        1619     1621       +2     
Files Coverage Δ
.../com/wire/kalium/logic/data/sync/SlowSyncStatus.kt 100.00% <100.00%> (ø)
...n/com/wire/kalium/logic/sync/slow/SlowSyncParam.kt 100.00% <100.00%> (ø)
.../com/wire/kalium/logic/sync/slow/SlowSyncWorker.kt 96.22% <100.00%> (+0.22%) ⬆️
.../wire/kalium/logic/data/sync/SlowSyncRepository.kt 65.51% <0.00%> (-3.45%) ⬇️
...m/wire/kalium/logic/data/user/AccountRepository.kt 63.33% <0.00%> (-2.19%) ⬇️
...com/wire/kalium/logic/sync/slow/SlowSyncManager.kt 93.67% <95.23%> (-0.45%) ⬇️
.../sync/slow/migration/SyncMigrationStepsProvider.kt 87.50% <87.50%> (ø)
...sync/slow/migration/steps/SyncMigrationStep_6_7.kt 90.90% <90.90%> (ø)

... and 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b1cb22e...53d1af5. Read the comment docs.

Copy link
Member

@vitorhugods vitorhugods left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. Just some tiny suggestions and one possible bug found.

@MohamadJaara MohamadJaara added this pull request to the merge queue Nov 14, 2023
Merged via the queue into develop with commit 83cdfef Nov 14, 2023
15 checks passed
@MohamadJaara MohamadJaara deleted the fix/disable-status-update-for-private-users branch November 14, 2023 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants