-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(sync): pull feature flags when online [WPB-5403] #2208
Merged
vitorhugods
merged 3 commits into
release/candidate
from
feat/pull-team-configs-and-feature-flags-when-online
Nov 8, 2023
Merged
feat(sync): pull feature flags when online [WPB-5403] #2208
vitorhugods
merged 3 commits into
release/candidate
from
feat/pull-team-configs-and-feature-flags-when-online
Nov 8, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On big teams, the user may not be notified when feature flags change, so we need to manually pull this information from the backend.
vitorhugods
requested review from
saleniuk,
a team,
typfel,
gongracr,
yamilmedina and
ohassine
and removed request for
a team
November 8, 2023 13:52
…ure-flags-when-online
yamilmedina
reviewed
Nov 8, 2023
.../src/commonMain/kotlin/com/wire/kalium/logic/feature/featureConfig/FeatureFlagsSyncWorker.kt
Outdated
Show resolved
Hide resolved
yamilmedina
approved these changes
Nov 8, 2023
alexandreferris
approved these changes
Nov 8, 2023
…ureConfig/FeatureFlagsSyncWorker.kt Co-authored-by: Yamil Medina <[email protected]>
saleniuk
approved these changes
Nov 8, 2023
Codecov Report
@@ Coverage Diff @@
## release/candidate #2208 +/- ##
====================================================
Coverage ? 58.21%
Complexity ? 21
====================================================
Files ? 1011
Lines ? 37770
Branches ? 3440
====================================================
Hits ? 21986
Misses ? 14317
Partials ? 1467 Continue to review full report in Codecov by Sentry.
|
vitorhugods
deleted the
feat/pull-team-configs-and-feature-flags-when-online
branch
November 8, 2023 14:35
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Issues
On big teams, the user may not be notified when feature flags change.
Causes
Backend limitation.
Solutions
Fetch every 1h or so, when becoming online.
Rely on similar mechanisms that we already have for uploading keypackages and prekeys, for example: observe incremental sync status.
This way, when the app becomes online, it will fetch the feature configs if:
Testing
Test Coverage
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.