Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rc): persist proper team members user types [WPB-5343] #2211

Merged

Conversation

saleniuk
Copy link
Contributor

@saleniuk saleniuk commented Nov 8, 2023


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

The only place where the user type for team members was determined and stored was during the slow sync, but for large teams, members list is ignored, not fully fetched and not stored so we were losing this information.

Solutions

Fetch member permissions when searching and fetching users when slow syncing and opening profile so that we always store team members with proper user types.

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

Copy link
Contributor

github-actions bot commented Nov 8, 2023

Unit Test Results

   413 files     413 suites   20s ⏱️
2 272 tests 2 152 ✔️ 120 💤 0

Results for commit 3fc084b.

♻️ This comment has been updated with latest results.

@datadog-wireapp
Copy link

datadog-wireapp bot commented Nov 8, 2023

Datadog Report

All test runs 8e3afe7 🔗

2 Total Test Services: 0 Failed, 0 with New Flaky, 2 Passed

Test Services
Service Name Failed Known Flaky New Flaky Passed Skipped Wall Time Branch View
kalium-ios 0 0 0 2152 120 7m 27s Link
kalium-jvm 0 0 0 2269 98 6m 43s Link

@saleniuk saleniuk requested review from a team, alexandreferris, borichellow, MohamadJaara, vitorhugods and Garzas and removed request for a team November 9, 2023 09:06
@MohamadJaara MohamadJaara merged commit 1f72f19 into release/candidate Nov 9, 2023
12 checks passed
@MohamadJaara MohamadJaara deleted the fix/persist_proper_team_member_usertype_rc branch November 9, 2023 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants