Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: add more info to generic core failure logs #2218

Merged

Conversation

MohamadJaara
Copy link
Member


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

generic errors are missing the stack trace when logged

Solutions

overwrite the toString fun to include info about the stack trace leading to the generic error

Dependencies (Optional)

If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

Copy link
Contributor

github-actions bot commented Nov 13, 2023

Unit Test Results

   470 files  ±0     470 suites  ±0   3m 41s ⏱️ + 1m 3s
2 622 tests ±0  2 518 ✔️ ±0  104 💤 ±0  0 ±0 

Results for commit 10199c8. ± Comparison against base commit b1cb22e.

♻️ This comment has been updated with latest results.

@datadog-wireapp
Copy link

datadog-wireapp bot commented Nov 13, 2023

Datadog Report

All test runs dca7bc9 🔗

2 Total Test Services: 0 Failed, 0 with New Flaky, 2 Passed

Test Services
Service Name Failed Known Flaky New Flaky Passed Skipped Wall Time Branch View
kalium-ios 0 0 0 1814 30 13s Link
kalium-jvm 0 0 0 2518 104 14m 48s Link

@ohassine ohassine enabled auto-merge November 13, 2023 12:09
@ohassine ohassine added this pull request to the merge queue Nov 13, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #2218 (10199c8) into develop (b1cb22e) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@              Coverage Diff              @@
##             develop    #2218      +/-   ##
=============================================
- Coverage      58.02%   58.02%   -0.01%     
  Complexity        21       21              
=============================================
  Files           1070     1070              
  Lines          40701    40702       +1     
  Branches        3766     3766              
=============================================
- Hits           23617    23616       -1     
- Misses         15465    15467       +2     
  Partials        1619     1619              
Files Coverage Δ
...onMain/kotlin/com/wire/kalium/logic/CoreFailure.kt 21.31% <100.00%> (+0.65%) ⬆️

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b1cb22e...10199c8. Read the comment docs.

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 13, 2023
@MohamadJaara MohamadJaara added this pull request to the merge queue Nov 13, 2023
Merged via the queue into develop with commit 7cbe0fe Nov 13, 2023
16 checks passed
@MohamadJaara MohamadJaara deleted the refactor/add-more-information-to-generic-core-failure branch November 13, 2023 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants