feat: Ask user about messaging in Degraded conversation (WPB-1771) #2220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
borichellow
requested review from
typfel,
yamilmedina,
alexandreferris,
mchenani,
Garzas and
saleniuk
mchenani
reviewed
Nov 13, 2023
| @@ -1056,6 +1061,19 @@ internal class ConversationDataSource internal constructor( | |||
| } | |||
| } | |||
|
|
|||
| override suspend fun updateInformAboutVerificationBeforeMessagingFlag( | |||
There was a problem hiding this comment.
Suggested change
| override suspend fun updateInformAboutVerificationBeforeMessagingFlag( | |
| override suspend fun setInformAboutVerificationBeforeMessagingFlag( |
mchenani
reviewed
Nov 13, 2023
| @@ -1056,6 +1061,19 @@ internal class ConversationDataSource internal constructor( | |||
| } | |||
| } | |||
|
|
|||
| override suspend fun updateInformAboutVerificationBeforeMessagingFlag( | |||
| conversationId: QualifiedID, | |||
| updateFlag: Boolean | |||
There was a problem hiding this comment.
suggestion: updatedValue, or even value.
mchenani
reviewed
Nov 13, 2023
| @@ -42,7 +42,8 @@ CREATE TABLE Conversation ( | |||
| archived_date_time INTEGER AS Instant, | |||
| -- mls_verification_status | |||
| verification_status TEXT AS ConversationEntity.VerificationStatus NOT NULL DEFAULT "NOT_VERIFIED", | |||
| proteus_verification_status TEXT AS ConversationEntity.VerificationStatus NOT NULL DEFAULT "NOT_VERIFIED" | |||
| proteus_verification_status TEXT AS ConversationEntity.VerificationStatus NOT NULL DEFAULT "NOT_VERIFIED", | |||
| should_inform_about_verification_before_messaging INTEGER AS Boolean NOT NULL DEFAULT 0 | |||
There was a problem hiding this comment.
Suggested change
| should_inform_about_verification_before_messaging INTEGER AS Boolean NOT NULL DEFAULT 0 | |
| degraded_conversation_notified INTEGER AS Boolean NOT NULL DEFAULT 0 |
or
Suggested change
| should_inform_about_verification_before_messaging INTEGER AS Boolean NOT NULL DEFAULT 0 | |
| notified_degraded_conversation INTEGER AS Boolean NOT NULL DEFAULT 0 |
mchenani
approved these changes
Nov 13, 2023
Datadog ReportAll test runs ✅ 2 Total Test Services: 0 Failed, 0 with New Flaky, 2 Passed Test Services
|
alexandreferris
approved these changes
Nov 14, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
borichellow
deleted the
feat/ask_user_about_messaging_in_degraded_conversation
branch
echoes-hq
bot
added
the
echoes: product-roadmap
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's new in this PR?
Users need to be notified that the conversation where he/she going to send a message is degraded.
For that:
should_inform_about_verification_before_messagingflag intoConversationDB table