-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(e2ei): separate e2ei enrollment flow (WPB-5229) #2223
Conversation
…/e2ei/separate-e2ei-enrollment-steps
…/e2ei/separate-e2ei-enrollment-steps
…/e2ei/separate-e2ei-enrollment-steps
const val BASE_URL = "https://balderdash.hogwash.work" | ||
const val ACME_PORT = "9000" | ||
const val DEX_PORT = "5556" | ||
const val BASE_URL = "https://acme.diya.wire.link/acme/defaultteams" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI: this link will be removed and will be fetched from the team-settings.
…nt-steps' into feat/e2ei/separate-e2ei-enrollment-steps
Datadog ReportAll test runs ✅ 2 Total Test Services: 0 Failed, 0 with New Flaky, 2 Passed Test Services
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great job! 👍
just a small code-style suggestion :)
logic/src/commonMain/kotlin/com/wire/kalium/logic/feature/e2ei/usecase/EnrollE2EIUseCase.kt
Outdated
Show resolved
Hide resolved
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #2223 +/- ##
=============================================
- Coverage 58.00% 57.98% -0.03%
Complexity 21 21
=============================================
Files 1075 1075
Lines 40807 40817 +10
Branches 3777 3778 +1
=============================================
- Hits 23671 23668 -3
- Misses 15517 15529 +12
- Partials 1619 1620 +1
... and 3 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
…/e2ei/separate-e2ei-enrollment-steps # Conflicts: # logic/src/commonMain/kotlin/com/wire/kalium/logic/CoreFailure.kt
logic/src/commonMain/kotlin/com/wire/kalium/logic/data/e2ei/E2EIRepository.kt
Outdated
Show resolved
Hide resolved
cryptography/src/commonMain/kotlin/com/wire/kalium/cryptography/E2EIClient.kt
Show resolved
Hide resolved
…nt-steps' into feat/e2ei/separate-e2ei-enrollment-steps
…nt-steps' into feat/e2ei/separate-e2ei-enrollment-steps
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Since the enrollment process has three big flows. initialisation, oAuth and finalisation+ getting certificate, and of the oAuth we have to wait for the AR app to provide the idToken, so we needed to split the useCase into two parts, initialisation and finalisation.
Solutions
Splitting the usecase invoke into two functions.
Needs releases with:
Testing
Test Coverage (Optional)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.