Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(e2ei): separate e2ei enrollment flow (WPB-5229) #2223

Merged
merged 21 commits into from
Nov 17, 2023

Conversation

mchenani
Copy link
Contributor


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Since the enrollment process has three big flows. initialisation, oAuth and finalisation+ getting certificate, and of the oAuth we have to wait for the AR app to provide the idToken, so we needed to split the useCase into two parts, initialisation and finalisation.

Solutions

Splitting the usecase invoke into two functions.

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution
  • [ ]

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@mchenani mchenani changed the title feat(e2ei): separate e2ei enrollment flow feat(e2ei): separate e2ei enrollment flow (WPB-5229) Nov 14, 2023
const val BASE_URL = "https://balderdash.hogwash.work"
const val ACME_PORT = "9000"
const val DEX_PORT = "5556"
const val BASE_URL = "https://acme.diya.wire.link/acme/defaultteams"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI: this link will be removed and will be fetched from the team-settings.

Copy link
Contributor

github-actions bot commented Nov 14, 2023

Unit Test Results

   394 files   -   78     394 suites   - 78   15s ⏱️ - 2m 4s
2 081 tests  - 549  2 014 ✔️  - 512  67 💤  - 37  0 ±0 

Results for commit 36e7112. ± Comparison against base commit 78a0841.

♻️ This comment has been updated with latest results.

@datadog-wireapp
Copy link

datadog-wireapp bot commented Nov 14, 2023

Datadog Report

All test runs 940017a 🔗

2 Total Test Services: 0 Failed, 0 with New Flaky, 2 Passed

Test Services
Service Name Failed Known Flaky New Flaky Passed Skipped Wall Time Branch View
kalium-ios 0 0 0 2014 67 7m 24.1s Link
kalium-jvm 0 0 0 2531 104 7m 38.06s Link

Copy link
Contributor

@borichellow borichellow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great job! 👍
just a small code-style suggestion :)

@codecov-commenter
Copy link

codecov-commenter commented Nov 15, 2023

Codecov Report

Merging #2223 (36e7112) into develop (78a0841) will decrease coverage by 0.03%.
The diff coverage is 74.19%.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #2223      +/-   ##
=============================================
- Coverage      58.00%   57.98%   -0.03%     
  Complexity        21       21              
=============================================
  Files           1075     1075              
  Lines          40807    40817      +10     
  Branches        3777     3778       +1     
=============================================
- Hits           23671    23668       -3     
- Misses         15517    15529      +12     
- Partials        1619     1620       +1     
Files Coverage Δ
.../kotlin/com/wire/kalium/cryptography/E2EIClient.kt 100.00% <100.00%> (ø)
...monMain/kotlin/com/wire/kalium/cryptography/IDs.kt 89.74% <100.00%> (ø)
.../com/wire/kalium/logic/data/e2ei/E2EIRepository.kt 87.38% <100.00%> (+0.35%) ⬆️
...re/kalium/network/api/base/unbound/acme/ACMEApi.kt 51.85% <100.00%> (ø)
...ire/kalium/logic/data/client/E2EIClientProvider.kt 86.48% <0.00%> (ø)
...gic/data/conversation/MLSConversationRepository.kt 85.59% <0.00%> (ø)
...um/logic/feature/e2ei/usecase/EnrollE2EIUseCase.kt 94.36% <86.66%> (-5.64%) ⬇️
.../kotlin/com/wire/kalium/logic/functional/Either.kt 26.53% <0.00%> (-2.36%) ⬇️
...onMain/kotlin/com/wire/kalium/logic/CoreFailure.kt 20.47% <14.28%> (-0.84%) ⬇️

... and 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 78a0841...36e7112. Read the comment docs.

…/e2ei/separate-e2ei-enrollment-steps

# Conflicts:
#	logic/src/commonMain/kotlin/com/wire/kalium/logic/CoreFailure.kt
@mchenani mchenani enabled auto-merge November 17, 2023 09:14
@mchenani mchenani added this pull request to the merge queue Nov 17, 2023
Merged via the queue into develop with commit b80ce0f Nov 17, 2023
15 checks passed
@mchenani mchenani deleted the feat/e2ei/separate-e2ei-enrollment-steps branch November 17, 2023 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants