Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ignore unknown feature config #2224

Merged
merged 3 commits into from
Nov 15, 2023

Conversation

MohamadJaara
Copy link
Member


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

unknown feature config event stoping sync

Solutions

ignore unknown feature config

Dependencies (Optional)

If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

Copy link
Contributor

github-actions bot commented Nov 14, 2023

Unit Test Results

   342 files   - 130     342 suites   - 130   11s ⏱️ - 2m 21s
1 852 tests  - 779  1 822 ✔️  - 705  30 💤  - 74  0 ±0 

Results for commit c58dbda. ± Comparison against base commit b0c7e37.

♻️ This comment has been updated with latest results.

@codecov-commenter
Copy link

Codecov Report

Merging #2224 (c58dbda) into develop (b0c7e37) will increase coverage by 0.01%.
The diff coverage is 45.71%.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #2224      +/-   ##
=============================================
+ Coverage      57.98%   57.99%   +0.01%     
  Complexity        21       21              
=============================================
  Files           1075     1075              
  Lines          40805    40801       -4     
  Branches        3780     3778       -2     
=============================================
+ Hits           23660    23662       +2     
+ Misses         15525    15517       -8     
- Partials        1620     1622       +2     
Files Coverage Δ
...onMain/kotlin/com/wire/kalium/logic/CoreFailure.kt 21.31% <ø> (ø)
...re/kalium/logic/sync/incremental/EventProcessor.kt 67.56% <30.76%> (-5.61%) ⬇️
.../logic/sync/receiver/FeatureConfigEventReceiver.kt 75.60% <54.54%> (+17.07%) ⬆️

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b0c7e37...c58dbda. Read the comment docs.

@datadog-wireapp
Copy link

datadog-wireapp bot commented Nov 14, 2023

Datadog Report

All test runs eb5ea8e 🔗

2 Total Test Services: 0 Failed, 0 with New Flaky, 2 Passed

Test Services
Service Name Failed Known Flaky New Flaky Passed Skipped Wall Time Branch View
kalium-ios 0 0 0 1822 30 11.09s Link
kalium-jvm 0 0 0 2527 104 7m 29.04s Link

@MohamadJaara MohamadJaara requested review from a team, typfel, gongracr, yamilmedina, ohassine and saleniuk and removed request for a team November 15, 2023 12:47
@MohamadJaara MohamadJaara added this pull request to the merge queue Nov 15, 2023
Merged via the queue into develop with commit b29d505 Nov 15, 2023
15 checks passed
@MohamadJaara MohamadJaara deleted the fix/ignore-unknown-feature-config branch November 15, 2023 17:09
MohamadJaara added a commit that referenced this pull request Nov 16, 2023
* feat: ignore unknown feature config

* detekt

(cherry picked from commit b29d505)
MohamadJaara added a commit that referenced this pull request Nov 16, 2023
* feat: ignore unknown feature config

* detekt

(cherry picked from commit b29d505)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants