-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add more logging on testservice and possibility to set development api on instance creation #2225
Conversation
instancePath, | ||
instanceRequest.password, | ||
System.currentTimeMillis() - before, | ||
System.currentTimeMillis() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion: could you please define these parameters as variables then it would be clear what are these and why we have them like this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. I commited a small fix.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, added one comment.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #2225 +/- ##
=============================================
- Coverage 57.98% 57.98% -0.01%
Complexity 21 21
=============================================
Files 1075 1075
Lines 40805 40805
Branches 3780 3780
=============================================
- Hits 23660 23659 -1
- Misses 15525 15526 +1
Partials 1620 1620
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Datadog ReportAll test runs ✅ 2 Total Test Services: 0 Failed, 0 with New Flaky, 2 Passed Test Services
|
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Issues
We currently experience issues with stability. Additionally we had hardcoded development api setting.
Solutions
This PR moves all logging into dropwizard application.log file and adds a new option on instance creation to enable/disable development api support.
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.