Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add more logging on testservice and possibility to set development api on instance creation #2225

Merged
merged 15 commits into from
Nov 16, 2023

Conversation

mythsunwind
Copy link
Collaborator


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

We currently experience issues with stability. Additionally we had hardcoded development api setting.

Solutions

This PR moves all logging into dropwizard application.log file and adds a new option on instance creation to enable/disable development api support.


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

instancePath,
instanceRequest.password,
System.currentTimeMillis() - before,
System.currentTimeMillis()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: could you please define these parameters as variables then it would be clear what are these and why we have them like this?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I commited a small fix.

Copy link
Contributor

@mchenani mchenani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, added one comment.

Copy link
Contributor

github-actions bot commented Nov 14, 2023

Unit Test Results

   342 files   - 130     342 suites   - 130   11s ⏱️ - 2m 21s
1 852 tests  - 779  1 822 ✔️  - 705  30 💤  - 74  0 ±0 

Results for commit 5ff3cbf. ± Comparison against base commit b0c7e37.

♻️ This comment has been updated with latest results.

@mythsunwind mythsunwind requested a review from ohassine November 14, 2023 17:54
@codecov-commenter
Copy link

codecov-commenter commented Nov 14, 2023

Codecov Report

Merging #2225 (5ff3cbf) into develop (b0c7e37) will decrease coverage by 0.01%.
The diff coverage is n/a.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #2225      +/-   ##
=============================================
- Coverage      57.98%   57.98%   -0.01%     
  Complexity        21       21              
=============================================
  Files           1075     1075              
  Lines          40805    40805              
  Branches        3780     3780              
=============================================
- Hits           23660    23659       -1     
- Misses         15525    15526       +1     
  Partials        1620     1620              
Files Coverage Δ
...monMain/kotlin/com/wire/kalium/logic/CoreLogger.kt 23.07% <ø> (ø)

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b0c7e37...5ff3cbf. Read the comment docs.

@datadog-wireapp
Copy link

datadog-wireapp bot commented Nov 14, 2023

Datadog Report

All test runs 28b515d 🔗

2 Total Test Services: 0 Failed, 0 with New Flaky, 2 Passed

Test Services
Service Name Failed Known Flaky New Flaky Passed Skipped Wall Time Branch View
kalium-ios 0 0 0 1822 30 11.11s Link
kalium-jvm 0 0 0 2527 104 7m 10s Link

@MohamadJaara MohamadJaara added this pull request to the merge queue Nov 16, 2023
Merged via the queue into develop with commit 701778c Nov 16, 2023
15 checks passed
@MohamadJaara MohamadJaara deleted the feat/testservice-debugging branch November 16, 2023 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants