Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump avs version to 9.5.5 (#2222) #2227

Merged
merged 2 commits into from
Nov 16, 2023

Conversation

MohamadJaara
Copy link
Member


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Briefly describe the issue you have solved or implemented with this pull request. If the PR contains multiple issues, use a bullet list.

Causes (Optional)

Briefly describe the causes behind the issues. This could be helpful to understand the adopted solutions behind some nasty bugs or complex issues.

Solutions

Briefly describe the solutions you have implemented for the issues explained above.

Dependencies (Optional)

If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@MohamadJaara MohamadJaara changed the base branch from develop to release/candidate November 15, 2023 12:51
Copy link
Contributor

github-actions bot commented Nov 15, 2023

Unit Test Results

   472 files     472 suites   2m 25s ⏱️
2 631 tests 2 527 ✔️ 104 💤 0

Results for commit 948fc5d.

♻️ This comment has been updated with latest results.

@codecov-commenter
Copy link

Codecov Report

Merging #2227 (bb3579c) into release/candidate (83cdfef) will decrease coverage by 0.09%.
The diff coverage is n/a.

Additional details and impacted files
@@                   Coverage Diff                   @@
##             release/candidate    #2227      +/-   ##
=======================================================
- Coverage                58.07%   57.98%   -0.09%     
  Complexity                  21       21              
=======================================================
  Files                     1073     1075       +2     
  Lines                    40749    40805      +56     
  Branches                  3778     3780       +2     
=======================================================
- Hits                     23663    23660       -3     
- Misses                   15466    15524      +58     
- Partials                  1620     1621       +1     

see 13 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 83cdfef...bb3579c. Read the comment docs.

@MohamadJaara MohamadJaara enabled auto-merge (squash) November 15, 2023 13:41
@MohamadJaara MohamadJaara merged commit 8fb8645 into release/candidate Nov 16, 2023
13 of 14 checks passed
@MohamadJaara MohamadJaara deleted the chore/bump-avs branch November 16, 2023 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants