Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: SessionManager missing session error #2228

Merged

Conversation

MohamadJaara
Copy link
Member

@MohamadJaara MohamadJaara commented Nov 15, 2023


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

SessionManager session not found error

Causes (Optional)

  1. shared preferences write into memory first for speed (this can be changed, but there is no need to).
  2. if any app crash happens right after login, the session will not be written into disk
  3. Kaboom session not found.

Solutions

handle missing session by logging out the user in case of session not found

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

Copy link
Contributor

github-actions bot commented Nov 15, 2023

Unit Test Results

   445 files   -   27     445 suites   - 27   20s ⏱️ - 2m 38s
2 514 tests  - 117  2 395 ✔️  - 132  119 💤 +15  0 ±0 

Results for commit 5dbadcf. ± Comparison against base commit 83cdfef.

♻️ This comment has been updated with latest results.

@datadog-wireapp
Copy link

datadog-wireapp bot commented Nov 15, 2023

Datadog Report

All test runs 0f53e54 🔗

2 Total Test Services: 0 Failed, 0 with New Flaky, 2 Passed

Test Services
Service Name Failed Known Flaky New Flaky Passed Skipped Wall Time Branch View
kalium-ios 0 0 0 2395 119 7m 35.11s Link
kalium-jvm 0 0 0 2527 104 7m 16.04s Link

@MohamadJaara MohamadJaara merged commit a6c1110 into release/candidate Nov 15, 2023
15 checks passed
@MohamadJaara MohamadJaara deleted the fix/session-manager-missing-session-error branch November 15, 2023 19:35
github-actions bot pushed a commit that referenced this pull request Nov 15, 2023
* fix: SessionManager missing session error

* detekt

* add test

* detekt
github-merge-queue bot pushed a commit that referenced this pull request Nov 16, 2023
* fix: SessionManager missing session error

* detekt

* add test

* detekt

Co-authored-by: Mohamad Jaara <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants